End-to-end tests of the admin's daily loop on the image (A-45)

Aperta
#3,456 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, docker, github-actions, playwright, sqlite
Ambito
backend, ci-cd, testing

Direzione di ricerca

Start with admin/tests/FluentCMS.Admin.EndToEnd/EndToEndHost.cs, .github/workflows/compose.yml, and src/FluentCMS.Host/Dockerfile; read sections 6.1, 7, 9, and 10.8 of docs/planning/admin-technical-spec.md for the design. Run the end-to-end project through the proposed image mode and its retry path. Done means the acceptance checklist passes, including container cleanup, documented job behavior, and an unchanged publish run.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:admin area:testing type:feature

Problem

The exit criteria of A7 ask that the end-to-end and accessibility checks pass on the image. They have never run on it:

  • The harness runs a publish, not the image. EndToEndHost publishes the reference host with no build and runs dotnet FluentCMS.Host.dll as a child process, in Production on SQLite with the Blog sample, and runs the host's commands with dotnet exec (admin/tests/FluentCMS.Admin.EndToEnd/EndToEndHost.cs, lines 15 to 19, 259 and 325).
  • The image meets no browser. The Compose workflow builds the image and checks it with curl: the admin page with its base and its policy, config.json, one file of the framework, and the code flow of the admin's client (.github/workflows/compose.yml, step "Smoke test"). No page of the admin is drawn.
  • What only the image has. The list of COPY lines of src/FluentCMS.Host/Dockerfile, to which A-51 had to add one for its new project; the publish for the target architecture; the chiseled base image with no shell and a user that is not root; and SQLite in the /data volume. A file the image lacks, or one the user of the image cannot read, would be found by the first person who opens /admin of a release.

Proposal

  • A second way to run the host. FLUENTCMS_E2E_IMAGE names an image, and the harness then runs the host as a container of it through the docker command: the settings of Configure() as environment variables, the run's certificates and landing.schema.json mounted read-only, /data as a volume of the run, and the https port published on the loopback address. The commands (migrate, user create, apikey create) run as one-off containers on the same volume, as docs/docker.md shows an operator. Unset, the harness publishes and runs as today. The two ways sit behind one type that starts the host, runs a command, gives the logs and stops it.
  • No proxy. Kestrel in the container answers https with the run's certificate, as the child process does, so no second container is needed.
  • A job. End-to-end on the image (admin) builds the image once and runs the whole end-to-end project against it through run-with-retry.ps1, whose second run takes the same image. It runs where the Compose workflow runs: on pushes to main and to feature branches, and on manual runs, not on issue pull requests. A manual run takes the name of a published image, as Compose does, so that a release can be checked after it is pushed.
  • The publish run stays in End-to-end (admin) on every full run: it needs no image build, and it is what a developer runs.
  • Without Docker the image run is skipped with a message, as the media storage tests are; in CI a skip fails the job.
  • What rides along. The axe-core sweep (A-42) and the keyboard loop (A-54) are classes of the same project and run on the image with no further work. The right-to-left run needs the pseudo-cultures of A-53, which a release image does not hold, so it stays on the publish.

Acceptance

  • With FLUENTCMS_E2E_IMAGE set, every end-to-end case passes against a container of the image, with the editor made by the image's own command
  • The job runs on a push to main and to a feature branch and on a manual run, and with the name of a published image it runs that image without building
  • A case that fails is run once more against the same image, and a flaky case is named as today
  • An image built without one admin project's COPY line, or without the admin's files, fails the job
  • The containers, the volume and the certificates of a run are removed at its end, also when the run is cancelled
  • Without Docker the image run is skipped with the reason, and the publish run is unchanged
  • Section 7 and CONTRIBUTING.md describe the job, and the pull request states its time

Design: docs/planning/admin-technical-spec.md, sections 6.1, 7, 9 and 10.8 (A-45). Rows 3.19, 10.2. A-56, which takes Firefox and WebKit of the row in 10.8, needs it. Size: M.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.