[firebase_auth]: authStateChanges() never emits null when the user is force-signed-out before the stream is listened to (iOS, macOS, Android)
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 15/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Ambito
- authentication, mobile
Direzione di ricerca
Work is already in progress: pull request #18797 is open against this issue, so review or build on it rather than starting a parallel fix. The first-callback handling lives in FLTAuthStateChannelStreamHandler.swift and FLTIdTokenChannelStreamHandler.swift (iOS and macOS) and in AuthStateChannelStreamHandler.kt and IdTokenChannelStreamHandler.kt (Android), with the Dart side in the auth state handlers. Done means a null first callback reaches Dart, a normal signed-in launch is unchanged, and the 'fires once on first initialization' test still passes.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is there an existing issue for this? I have searched the existing issues. #10230 is related, but it covers a running app with no token refresh.
Which plugins are affected? Auth
Which platforms are affected? Android, iOS, macOS
Description
If Firebase Auth signs the user out on its own before the app listens to authStateChanges() or idTokenChanges(), the Dart side never finds out. FirebaseAuth.instance.currentUser keeps returning the old user for the rest of the process, and all three streams keep emitting that user. Calls that need a token fail with [firebase_auth/no-current-user], Firestore rejects every request with permission-denied, and the app stays on its signed-in UI.
The usual trigger is a revoked refresh token, for example after a password change on another device or an Admin SDK revokeRefreshTokens() call. On the next cold start after the cached ID token has expired, the first token refresh fails and the native SDK signs the user out (on Apple it logs [FirebaseAuth][I-AUT000016] Invalid user token detected, user is automatically signed out.). In our app that happened 1 to 5 seconds after launch, which can be before the first authStateChanges() subscription exists.
The Apple and Android stream handlers drop the first native listener callback unconditionally, because Dart already has an initial value (APP_CURRENT_USER from the plugin constants). You can see it in FLTAuthStateChannelStreamHandler.swift and FLTIdTokenChannelStreamHandler.swift (iOS and macOS) and in AuthStateChannelStreamHandler.kt / IdTokenChannelStreamHandler.kt (Android), where initialAuthState makes the first callback return early. If the native user is already nil when the listener is registered, that first callback is the sign-out, and it gets dropped. On Apple no second nil follows, because addStateDidChangeListener only forwards uid changes. Calling signOut() from Dart afterwards doesn't fix it: the native SDK is already signed out, returns early, and sends no event.
This also breaks signing back in. After the user signs out manually and signs in again with the same account, Dart still holds that user, so apps that react to a change of user see nothing new, and navigation after sign-in can stall until the app is restarted.
Windows (firebase_auth_plugin.cpp) and web forward every callback and aren't affected.
Proposed fix: keep dropping the first callback when it carries a user, and forward it when the user is nil. On its own that would give a fresh signed-out app a second null event, which is what the "fires once on first initialization" test guards against (#3628), so the Dart handlers should also skip a null event when currentUser is already null. A normal signed-in launch behaves as before. I'll open a PR with both changes.
Reproducing the issue
- Sign in with email/password on macOS, iOS or Android, then quit the app.
- Revoke the user's refresh tokens (Admin SDK
revokeRefreshTokens(uid), or change the password from another client). - Wait at least an hour so the cached ID token expires.
- Launch the app and subscribe to
FirebaseAuth.instance.authStateChanges()a few seconds after startup, or after any early call that refreshes the token, such ascurrentUser!.getIdTokenResult()or a Firestore read. - Expected: the stream emits
nullandcurrentUserisnull. Actual: the stream emits the old user,currentUserstays non-null, token-dependent calls fail, and the native log shows the automatic sign-out.
We reproduced this on macOS with firebase_auth 6.7.0. With the proposed change, the app gets null and routes to sign-in, and signing in again works without a restart.
Firebase Core version: 4.15.0 (firebase_auth 6.7.0, firebase-ios-sdk 12.19.0, Android firebase-auth 24.2.0)
Flutter Version: 3.44.8 stable
Relevant Log Output
[FirebaseAuth][I-AUT000016] Invalid user token detected, user is automatically signed out.
[FirebaseFirestore][I-FST000001] Listen for query at users/<uid> failed: Missing or insufficient permissions.
FirebaseAuthException: [firebase_auth/no-current-user] No user currently signed in.
- Lingua principale
- Dart
- Stelle
- 9.3k
- Fork
- 4.1k
- Merge medio
- 2g 8h
- PR unite (30g)
- 46
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di firebase/flutterfire
-
blocked: customer-response Needs Attention platform: ios plugin: messaging type: bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
firebase/flutterfire#18776 · 4 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[📚] Remote Config Windows Support still N/A on ReadmeForse già presa @nightcityblade l’ha presa 7 giorni fa. Apertablocked: customer-response good first issue Needs Attention platform: windows plugin: remote_config type: documentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 30/100
firebase/flutterfire#18763 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[cloud_firestore]: a snapshots() listener cancelled while it registers is never removed nativelyForse già presa @chiliec l’ha presa 19 giorni fa. ApertaNeeds Attention platform: android platform: ios platform: macos plugin: cloud_firestore reproduced type: bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
firebase/flutterfire#18724 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[firebase_storage] Windows native crash in upload progress callback, sink ownership and thread dispatchForse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Apertablocked: flutter platform: windows plugin: storage reproduced type: bug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
firebase/flutterfire#18664 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[core] Decouple platform_interface from Flutter for pure-Dart webForse già presa @Lyokone l’ha presa 28 giorni fa. ApertaNeeds Attention platform: all platform: web plugin: core type: enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
firebase/flutterfire#18645 · 3 commenti · 2 reazioni · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di firebase/flutterfire
Issue simili
-
bug documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
fdittgen-png/deskilo#2605 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: The daily reminder keeps its old language after the app language changesForse già presa Una pull request collegata a questa issue è aperta o già unita. Apertabacklog:low bug localization
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
simonoppowa/OpenNutriTracker#1366 ·
I maintainer di solito rispondono entro 1 giorno
-
Mobile reading view shows a sender without display name as "<[email protected]>" with angle bracketsApertaai-driven-qa bug Cosmetic
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
linagora/tmail-flutter#4999 ·
I maintainer di solito rispondono entro 1 giorno
-
waiting for response
Difficoltà 2/5 Meno di un'ora Idoneità per principianti 72/100
flutter/flutter#194381 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno