[firebase_auth_web]: authStateChanges() never emits in --profile web builds (listener key 'no-op' collides)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- dart
- Ambito
- authentication, web-dev
Direzione di ricerca
Start with packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart and packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart, focusing on _authStateWindowsKey(), _idTokenStateWindowsKey(), and the listener storage methods. Reproduce with a Flutter web app using flutter build web --profile and multiple auth streams. Done means authStateChanges() emits its initial state in profile builds without cancelling another listener, while debug and release behavior remains intact.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is there an existing issue for this?
- I have searched the existing issues.
Which plugins are affected?
Auth, Core
Which platforms are affected?
Web
Description
In a flutter build web --profile build, FirebaseAuth.instance.authStateChanges() never emits. An app that waits for the first auth event (for example a router redirect that holds a splash screen until auth state is known) hangs forever. Debug and release builds work.
The JS SDK itself is fine. In the same page, onAuthStateChanged called directly through the JS SDK fires immediately with null.
Cause. The two packages disagree about what "debug" means:
firebase_auth_webbuilds the hot-restart listener key only under Flutter'skDebugMode.kDebugModeisfalsein profile, so every listener gets the same key,'no-op':
packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart,_authStateWindowsKey()/_idTokenStateWindowsKey():if (kDebugMode) { ... return '$key-${_authStateListeners[key]}'; } return 'no-op';firebase_core_webstores and cancels those listeners under its own flag, which istruein profile:
packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart:const bool _kDebugMode = !bool.fromEnvironment('dart.vm.product');setWindowsListener/unsubscribeWindowsListener/removeWindowsListenerare all gated on it.
So in profile, onAuthStateChanged / onIdTokenChanged store their JS unsubscribe function at window['no-op']. The next getter call runs unsubscribeWindowsListener('no-op'), which calls that stored function and cancels the previous subscription's JS listener. The Dart StreamController stays open but never receives an event. The event it seeded with _changeController!.add(_initUser) was added before any listener existed, so the broadcast controller dropped it.
In release both flags are false, and in debug both are true with unique keys, which is why only profile is affected.
The code is unchanged on main as of today.
Suggested fix: use the same condition in both places. For example, have firebase_core_web use kDebugMode from package:flutter/foundation.dart, or make _authStateWindowsKey() / _idTokenStateWindowsKey() always return a unique key.
Reproducing the issue
- Take any web app that listens to
FirebaseAuth.instance.authStateChanges()and also triggers a second auth stream (idTokenChanges(),userChanges(), or a secondauthStateChanges()call). flutter build web --profileand servebuild/web.- Open it signed out. The
authStateChanges()listener never fires. Withflutter run -d chromeorflutter build web --release, it firesnullstraight away.
To confirm it is the listener being cancelled, put prints in the stream: the provider builds and the redirect runs with the state still loading, but no event ever arrives. In the same page, firebase_auth.onAuthStateChanged(getAuth(app), cb) from the JS SDK fires at once.
Firebase Core version
4.15.0 (firebase_core_web 3.12.0)
Flutter Version
3.47.2
Relevant Log Output
No error is logged. The auth stream is silently cancelled.
Flutter dependencies
firebase_core: 4.15.0
firebase_core_web: 3.12.0
firebase_auth: 6.7.0
firebase_auth_web: 6.3.0
Additional context and comments
Found while profiling a production app. The fix above is based on reading the source, and the diagnosis was confirmed with print statements in a profile build. I have not built a standalone minimal repro project.
- Lingua principale
- Dart
- Stelle
- 9.3k
- Fork
- 4.1k
- Merge medio
- 2g 6h
- PR unite (30g)
- 38
Preparare l'ambiente
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di firebase/flutterfire
-
Needs Attention plugin: auth reproduced type: bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
firebase/flutterfire#18726 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Needs Attention platform: windows plugin: ai type: documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
firebase/flutterfire#18720 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[cloud_firestore]: a snapshots() listener cancelled while it registers is never removed nativelyApertaNeeds Attention platform: android platform: ios platform: macos plugin: cloud_firestore reproduced type: bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
firebase/flutterfire#18724 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
blocked: customer-response platform: web plugin: cloud_firestore type: bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
firebase/flutterfire#18700 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Needs Attention platform: ios plugin: messaging reproduced type: bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 74/100
firebase/flutterfire#18699 · 4 commenti · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di firebase/flutterfire
Issue simili
-
component: genui P2 status: first-line-handled type: bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
a2ui-project/a2ui#2854 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
openfoodfacts/smooth-app#7805 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
googleapis/google-cloud-dart#366 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
hiddify/hiddify-app#2353 ·
-
bug controls
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno