Remove deprecated config fields (proxyUrl, sslKeyPemPath, sslCertPemPath) in 3.0

Aperta
#1,545 1 commento 1 reazione 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@re-vlad ci sta già lavorando.

Dal 29/6/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

enhancement

Summary

Remove the deprecated top-level config fields proxyUrl, sslKeyPemPath, and sslCertPemPath from the schema, types, and config loader. These fields are already flagged deprecated: true in config.schema.json and have been superseded by upstreamProxy and tls.key / tls.cert respectively.

Why defer to 3.0

Removing these fields is a breaking change: after the upgrade, the app will fail to start unless users clean up their config files. That's not acceptable inside the 2.x line, so this work should land in the next major.

Context

  • Discussed in #1514 (review thread with @jescalada).
  • The removal was briefly included in #1514 as commit c48d0bf but reverted in 4234c16 to keep #1514 non-breaking.

Scope

  • Drop proxyUrl, sslKeyPemPath, sslCertPemPath from config.schema.json.
  • Regenerate src/config/generated/config.ts.
  • Remove the legacy fallback logic in src/config/index.ts (mergeConfigurations, getProxyUrl, getTLSKeyPemPath, getTLSCertPemPath).
  • Simplify FullGitProxyConfig to plain Required<GitProxyConfig> (drop OptionalTopLevelConfigKey).
  • Update reference docs (website/docs/configuration/reference.mdx).
  • Improve the config-load error message so users hitting a removed/unknown key get a clear "this field is no longer supported, use X" instead of the current misleading "expected boolean but got X" (per @jescalada's note in #1514).

Migration for users

Deprecated field Replacement
proxyUrl upstreamProxy
sslKeyPemPath tls.key
sslCertPemPath tls.cert
Lingua principale
TypeScript
Stelle
263
Fork
185
Merge medio
2g 15h
PR unite (30g)
39

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di finos/git-proxy

Tutte le issue di finos/git-proxy

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.