A descendant combinator after a complex :is() or :not() keeps answers it should not

Aperta
#1,929 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Aschenbath ci sta già lavorando.

Dal 8/11/2026.

  • #1940 di @Aschenbath — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, typescript
Ambito
web-dev

Direzione di ricerca

Start by reading compileToken, getQuality, and isCachedDescendant (named cachedDescendant in 7.0.0); the issue does not name source or test files. Run the two supplied reproductions with caching enabled and disabled, then trace why complex :is() or :not() selectors arm this cache. Done means the first example matches o m and the second reflects the updated document.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

isCachedDescendant (cachedDescendant in 7.0.0) keeps one answer per element for as long as the compiled function lives. It is armed by hasExpensiveSubselector, which compileToken sets for any rule getQuality rates 0. That is meant for :has() and :contains(), but :is() or :not() with a combinator inside rates 0 as well, because the combinator's -1 is clamped to 0.

The answer the cache keeps can depend on :scope, which :has() changes from one element to the next:

import { compile } from 'css-select';
import { parseDocument } from 'htmlparser2';
import { findAll } from 'domutils';

const doc = parseDocument(
  '<div class="c" id="o"><div class="b c" id="m"><span class="b c" id="t">' +
    '<input class="b" disabled></span></div></div>',
);
const elements = findAll((e) => !!e.attribs.id, doc.children);
const ids = (options) =>
  elements
    .filter(compile(':has(:is(.c .b) :disabled)', options))
    .map((e) => e.attribs.id)
    .join(' ');

console.log(ids({ xmlMode: false }));
// o m t, where Chrome 152 matches o m: nothing strictly inside #t is a
// `.c .b` with a :disabled in it
console.log(ids({ xmlMode: false, cacheResults: false }));
// o m

The same cache reaches a selector with no :has() or :contains() in it, which is less of a bug, since the README tells you to disable cacheResults if the document changes between queries, but it is easy to miss that :is() is among what it applies to:

import { compile } from 'css-select';
import { parseDocument } from 'htmlparser2';
import { findOne } from 'domutils';

const doc = parseDocument(
  '<div id="o"><div class="a"><span class="y" id="t"></span></div></div>',
);
const byId = (id) => findOne((e) => e.attribs.id === id, doc.children, true);
const matches = compile(':is(.x .a) .y', { xmlMode: false });

console.log(matches(byId('t'))); // false
byId('o').attribs.class = 'x';
console.log(matches(byId('t'))); // false, and true with cacheResults: false

What was tried. Turning the cached path off alone fixes both examples, so it is that cache and not the one in cacheParentResults. On a copy of 7.0.0, setting hasExpensiveSubselector only for has, contains and icontains rather than for every rule of quality 0 fixes both too, and leaves the cache for the selectors it was written for.

Run on css-select 7.0.0. master at 2b69f6c has the same logic under the new name, which I checked by reading it, not by running it.

Lingua principale
TypeScript
Stelle
636
Fork
85
Merge medio
1m
PR unite (30g)
13

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fb55/css-select

Tutte le issue di fb55/css-select

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.