config: dead-code sweep — write_value, combobox-era helpers, propose_config_creation, ConfigReader wrapper, WorkflowStep.evaluate_condition

Aperta
#142 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
52/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python

Direzione di ricerca

Start by reading the named helpers in src/profiles/core/config/ and checking their callers in src/ and tests/; inspect core/environment/workflow.py around the workflow condition evaluation. Remove the dead helpers, their re-exports and tests, and update core/config/__init__.py and AGENTS.md; for WorkflowStep.evaluate_condition, choose one evaluation seam. Done when the remaining production paths and tests use the retained APIs.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

code-quality

Dead code found in src/profiles/core/config/ (all verified by grepping src/ and tests/; complements the repo-wide #39 sweep)

  1. yaml_io.write_value (io/yaml_io.py:63-85) — zero production callers (only the io/__init__.py re-export and tests/core/config/io/test_yaml_io.py). Worse, it is the only non-atomic config writer left: plain p.open("w"), no temp file + os.replace — a crash mid-write truncates the user's config, exactly what #116 fixed elsewhere. Delete it, or reimplement on top of write_text_atomic if single-key writes are planned.

  2. Combobox-era helpers in service.py — get_directory_combobox_values (service.py:231-301), DirectoryEntry (service.py:22-35), find_config_by_name (service.py:75-89) — appear only in tests/core/config/test_service.py. The web UI consumes get_unique_directories + merge_config_overrides; no GUI module exists anymore.

  3. loader.propose_config_creation (loader.py:46-89) — dead in src/ (the real CLI path is app.init_default_config, the server path is launch.creation.propose_creation). It is also CLI I/O (print/input()) in the core layer (layering violation) and its ✓/✗ prints raise UnicodeEncodeError when stdout is piped through cp1252 on Windows.

  4. ConfigReader.find_configuration_by_hostname (reader.py:55-63) — wrapper with no production callers (production uses the pure service.find_configuration_by_hostname); when config=None it silently performs a full self.load() disk read — surprising I/O hidden behind a lookup-style method.

  5. WorkflowStep.evaluate_condition (models.py:94-102) — only called by tests; the engine bypasses it (core/environment/workflow.py:176-179 uses step.if_ + evaluate_hook_condition directly, because token substitution must happen first). Duplicated evaluation seam — remove or make the engine use it.

Suggested fix

Delete 1-4 (plus their re-exports and tests); for 5, pick one evaluation seam and remove the other. Update core/config/__init__.py __all__ and AGENTS.md in the same commit.

Lingua principale
Python
Stelle
1
Fork
1
Merge medio
4h 46m
PR unite (30g)
55

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di falbany/ProFiles

Tutte le issue di falbany/ProFiles

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.