tests/e2e: Docker installed by the panel before server-prep

Aperta
#128 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
bash, debian, docker, github-actions, shell, ubuntu

Direzione di ricerca

Read the existing docker-firewall checks and the CI scenario that provisions Debian or Ubuntu before editing the end-to-end harness. Add a run mode that installs Docker and starts a published-port container before server-prep.sh --config ci.cfg --yes, then verify external access is blocked, ufw route allow opens it, the DOCKER-USER chains are present, and fw.docker_bypass passes. Confirm the scenario fails when the 1.1.1 fix is reverted; the issue leaves the per-PR versus weekly OS matrix decision open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: ci area: prep claude enhancement panel: coolify priority: high security size: M

Epic #121 · Milestone Phase 1: Community & CI · Priority high · Size M · Depends on #94


Why

Coolify and Dokploy install Docker themselves. On a real server the panel often runs first, then server-prep. That order caused the ufw-docker bug fixed in 1.1.1 (ufw-docker check exits 0 even when the rules are missing, so the install was skipped when Docker was already running). Today the harness always lets server-prep install Docker, so this order is never tested.

What to do

  • A scenario (or a separate run mode) that installs Docker CE with the upstream convenience method or the distro package before server-prep.sh, and starts a container published with -p.
  • Assert the container port is reachable from the runner before server-prep (proves the gap exists).
  • Run server-prep.sh --config ci.cfg --yes, then reuse the docker-firewall checks: the port does not answer from outside, and the ufw route allow control opens it.
  • Assert iptables -S DOCKER-USER shows ufw-user-forward and the CrowdSec chain, and the audit's fw.docker_bypass is PASS.
  • Decide whether this needs its own VM boot per OS (run time) or runs on one OS per PR and all OSes weekly.

Acceptance criteria

  • Reverting the 1.1.1 fix (going back to ufw-docker check) turns this scenario red.
  • It passes on Debian 13 and Ubuntu 24.04 at least on every PR.
Lingua principale
Shell
Stelle
2
Fork
3
Merge medio
2g 14m
PR unite (30g)
47

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di exceev-consulting/server-prep

Tutte le issue di exceev-consulting/server-prep

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.