Automated accessibility checks for the desktop UI

Aperta
#202 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react

Direzione di ricerca

Read apps/desktop/ui/scripts/check-layout-browser.mjs and scripts/smoke.mjs to see how the project drives a headless browser, then inspect the mock-mode screens under apps/desktop/ui. The issue calls for an accessibility check covering at least ten screen or state combinations, a violation baseline and ratchet, CI integration, first-round fixes, and contributor documentation; done means the new check runs locally and in CI and the stated acceptance criteria pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

accessibility area: desktop-ui enhancement help wanted

size: M · first-timer: no

Summary

Add an automated accessibility check for the desktop UI that runs the main screens in mock mode in a headless browser, reports violations (roles, names, labels, focus, contrast, landmarks), and fails CI on regressions. Fix the first batch of findings.

Why it matters

The keyboard-only and screen-reader pass in #171 is a manual audit, and manual audits rot. An automated check keeps what that audit fixes from regressing and gives every contributor immediate feedback on new components.

Current state

  • The UI is React in apps/desktop/ui. It has check:themes (contrast of every theme) and check:layout/check:layout:browser, plus a real-app smoke harness (scripts/smoke.mjs); playwright-core is already a dev dependency and the scripts find Chrome through CHROME_BIN.
  • Mock mode (pnpm --dir apps/desktop/ui dev, then http://localhost:1420/?mock=1&screen=<name>&theme=<name>&lang=<en|tr>) renders every screen with canned data and needs no daemon.
  • There is no automated a11y tooling in the repository. A few components already set ARIA attributes and focus traps (components/Modal.tsx, lib/focusTrap.ts, lib/modalStack.ts, components/CommandPalette.tsx).
  • The shortcuts help is tracked in #165; the manual pass in #171.

Proposal and suggested approach

  1. A check:a11y script (next to check:layout:browser) that starts the dev server, opens each screen from a list (home, chat, bot panel, schedules, apps, settings sections, first-run wizard, a representative modal) in at least one dark and one light theme, injects axe-core, and prints violations grouped by rule and screen.
  2. Check the licence of the engine you pick against what the project allows (axe-core is MPL-2.0) and say so in the PR.
  3. A committed baseline of currently known violations with a ratchet: new violations fail, fixing one lets you remove it from the baseline. This lets the check land before every old problem is fixed.
  4. Fix a first batch of findings: unlabeled controls, icon-only buttons without accessible names, missing landmarks, dialogs without a name, focus order.
  5. A CI job (Linux only is fine) that runs it, and a paragraph in CONTRIBUTING.md next to the other checks.

Acceptance criteria

  • pnpm --dir apps/desktop/ui check:a11y runs locally and in CI, prints a readable summary, and exits non-zero on a new violation.
  • At least ten screens or states are covered, in two themes and both languages where text differs.
  • The baseline file exists and the first fixes are in; each fix keeps check:themes, check:i18n, UI tests, lint and typecheck green.
  • Documented in CONTRIBUTING.md.

Out of scope

The manual screen-reader pass (#171), redesigns, new themes, testing the Tauri shell itself.

How to get started

Read apps/desktop/ui/scripts/check-layout-browser.mjs and scripts/smoke.mjs for how a headless browser is driven, then open a few screens in mock mode. Comment here to claim it.

Lingua principale
Rust
Stelle
0
Fork
1
Merge medio
6h 54m
PR unite (30g)
152

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di emreocell/Praxi-Bot

Tutte le issue di emreocell/Praxi-Bot

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.