okl's own CI against the from-scratch guide: Sonar coverage, format gate, locked installs

Aperta
  • Qualcosa non va?
#331 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github-actions, python
Ambito
ci-cd, devops

Direzione di ricerca

The changes live in the CI workflow and .sonarcloud.properties; start by reading where CI runs ruff check, pip install -e . and uv lock --check. Run ruff format --check . locally to see the roughly 111 files it flags. Each change (Sonar coverage, format gate, uv sync --locked) should be its own PR, and the SonarCloud switch needs the maintainer's token, so pick a different item to start. Formatting touches most files, so it should land alone.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The from-scratch guide (#330) recommends practices this repository does not follow yet. The research for it found these, on 2026-11-01:

  • SonarCloud cannot see our coverage. We use automatic analysis (.sonarcloud.properties), and Sonar's docs say automatic analysis never imports coverage. Getting coverage into SonarCloud needs CI-based analysis: SonarSource/sonarqube-scan-action (pinned by SHA) with sonar.python.coverage.reportPaths=coverage.xml, fetch-depth: 0 and a SONAR_TOKEN secret.
  • Formatting is not gated. CI runs ruff check only. ruff format --check . reports about 111 files that would be reformatted. Adopting it is one reformatting commit plus a CI step. It would touch most files, so land it alone, with nothing else open against those files.
  • CI does not install from the lockfile. CI installs with pip install -e . and checks uv lock --check separately. uv sync --locked would test the locked versions themselves.
  • gitleaks is in maintenance mode. Its README says it is "feature complete… security patches only". Keep it, and watch its successor.

Each is a separate change, so pick them up one at a time. The SonarCloud switch needs the maintainer, who holds the token and the project settings.

🤖 Generated with Claude Code

Lingua principale
Python
Stelle
1
Fork
1
Merge medio
5h 22m
PR unite (30g)
119

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di emeraldleaf/okl

Tutte le issue di emeraldleaf/okl

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.