[Bug] Stamp annotations imported via importAnnotations are invisible

Aperta
#855 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, typescript
Ambito
frontend

Direzione di ricerca

Start by running the reproduction HTML from the issue: place a stamp, export with exportAnnotations, re-init, then importAnnotations, and check whether the stamp renders. The payload names only the annotation plugin API (importAnnotations, exportAnnotations, the stamp tool) and the stamp's ctx.data ArrayBuffer, not specific files. Done means a stamp imported from exported data renders in the same position as before the viewer was destroyed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

When exporting a stamp annotation and subsequently importing it back into a freshly initialized viewer via importAnnotations, the stamp becomes completely invisible.

The data exported by exportAnnotations contains a valid ArrayBuffer for the stamp's ctx.data, and importAnnotations accepts it without throwing any errors. However, the stamp fails to render visually. It seems the appearance stream (/AP) is being lost or ignored when the stamp is recreated during the import phase.

Steps to Reproduce

We have created a zero-dependency Minimal Reproducible Example (MRE) using the raw @embedpdf/snippet library to prove this is not related to external frameworks or serialization:

  1. Save the HTML file below and open it in a browser.
  2. Click "1. Init & Load PDF".
  3. Place a Stamp anywhere on the document.
  4. Click "2. Export & Destroy" (This saves the raw exportAnnotations() output to an in-memory variable and completely clears the DOM/viewer instance).
  5. Click "3. Re-Init & Import" (This spawns a fresh viewer, loads the PDF, and calls importAnnotations(savedAnnotations) using the raw memory data).
Expected Behavior

The stamp should be fully visible exactly where it was placed before the viewer was destroyed.

Actual Behavior

The import succeeds silently without errors, but the stamp is completely invisible on the document.

Minimal Reproducible Example
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>EmbedPDF Stamp MRE</title>
    <style>
        body, html { margin: 0; padding: 0; height: 100%; font-family: sans-serif; display: flex; flex-direction: column; }
        #controls { padding: 15px; background: #f0f0f0; border-bottom: 1px solid #ccc; display: flex; gap: 10px; align-items: center; }
        button { padding: 8px 16px; cursor: pointer; }
        #status { font-weight: bold; margin-left: 20px; color: #333; }
        #viewer-container { flex: 1; position: relative; background: #888; }
        #pdf-viewer { width: 100%; height: 100%; }
    </style>
</head>
<body>
    <div id="controls">
        <button id="btn-load">1. Init & Load PDF</button>
        <button id="btn-export">2. Export & Destroy</button>
        <button id="btn-import">3. Re-Init & Import</button>
        <span id="status">Ready. Click 'Init & Load PDF'</span>
    </div>
    <div id="viewer-container">
        <div id="pdf-viewer"></div>
    </div>

    <script type="module">
        import EmbedPDF from 'https://cdn.jsdelivr.net/npm/@embedpdf/snippet@2/dist/embedpdf.js';

        const pdfUrl = 'https://raw.githubusercontent.com/mozilla/pdf.js/ba2edeae/web/compressed.tracemonkey-pldi-09.pdf';
        
        let savedAnnotations = null;
        let viewerInstance = null;
        let annotationApi = null;
        
        async function initViewer() {
            const targetId = 'pdf-viewer';
            document.getElementById('viewer-container').innerHTML = `<div id="${targetId}"></div>`;
            
            viewerInstance = EmbedPDF.init({
                type: 'container',
                target: document.getElementById(targetId),
                documentManager: { maxDocuments: 1 }
            });
            
            const registry = await viewerInstance.registry;
            const docManager = registry.getPlugin('document-manager').provides();
            annotationApi = registry.getPlugin('annotation').provides();
            
            await docManager.openDocumentUrl({
                url: pdfUrl,
                documentId: 'test-document',
                autoActivate: true
            });
        }

        document.getElementById('btn-load').onclick = async () => {
            document.getElementById('status').textContent = 'Loading...';
            await initViewer();
            annotationApi.setActiveTool('stamp');
            document.getElementById('status').textContent = 'Loaded! Please place a STAMP, then click step 2.';
        };

        document.getElementById('btn-export').onclick = async () => {
            if (!annotationApi) return;
            document.getElementById('status').textContent = 'Exporting...';
            
            savedAnnotations = await new Promise((resolve) => {
                annotationApi.exportAnnotations().wait(
                    items => resolve(items),
                    err => { console.error(err); resolve([]); }
                );
            });
            
            document.getElementById('viewer-container').innerHTML = ''; 
            viewerInstance = null;
            annotationApi = null;
            document.getElementById('status').textContent = 'Destroyed! Annotations saved to variable. Now click step 3.';
        };

        document.getElementById('btn-import').onclick = async () => {
            if (!savedAnnotations) return alert("Please export first!");
            
            document.getElementById('status').textContent = 'Re-initializing...';
            await initViewer();
            
            const result = annotationApi.importAnnotations(savedAnnotations);
            if (result && typeof result.wait === 'function') {
                await new Promise(resolve => result.wait(resolve, resolve));
            }
            
            document.getElementById('status').textContent = 'Imported! The stamp is now invisible.';
        };
    </script>
</body>
</html>
Environment
  • EmbedPDF Version: @embedpdf/snippet@2
  • Browser: Firefox 156.01
  • OS: Arch Linux
Lingua principale
TypeScript
Stelle
4.5k
Fork
317
Merge medio
10h 16m
PR unite (30g)
174

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di embedpdf/embed-pdf-viewer

Tutte le issue di embedpdf/embed-pdf-viewer

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.