Remove the deprecated fake-* classes and abbreviated button class names in the next Skin major

Aperta
  • Qualcosa non va?
#1,069 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@ArtBlue ci sta già lavorando.

Dal 30/10/2026.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, react, sass, typescript
Ambito
developer-experience, frontend

Direzione di ricerca

Start with docs/adr/0009-static-component-boundaries.md and the framework-layer prerequisite list, then trace remaining selectors in button.scss, tabs.scss, link.scss, menu.scss and the named component styles. Update framework components, snapshots, stories, docs, tokens and selectors API as listed; confirm no in-scope legacy classes remain, then add the @ebay/skin major changeset. The issue says framework updates must land in a minor release before Skin removes the selectors.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

package: ebayui-core package: ebayui-core-react package: evo-web/marko package: evo-web/react package: skin semvar: breaking changes

Context

#1045 (PR #1070) deprecated two sets of Skin classes without removing them, so that release is not breaking. This issue removes both sets in the next major version.

The fake-* patterns became standalone components:

Removed Replacement
fake-btn button-link
fake-tabs navigation-tabs
fake-link link-button
fake-menu navigation-menu

The abbreviated button-family names gained spelled-out twins, including every element and modifier (btn__cell to button__cell, btn--primary to button--primary):

Removed Replacement
btn button
icon-btn icon-button
cta-btn cta-button
expand-btn expand-button

Decision record: docs/adr/0010-static-component-boundaries.md.

Prerequisite (blocks the removal)

The framework layers still emit the legacy classes. Each must move to the new classes in a minor release first, otherwise removing the Skin selectors breaks them. On 2026-10-27, source files (not snapshots) using an abbreviated button-family class: ebayui-core 17, evo-marko 7, ebayui-core-react 33, evo-react 11.

  • Button components that build the btn and fake-btn classes: ebayui-core/ebay-button, evo-marko/evo-button, ebayui-core-react/ebay-button, evo-react/button
  • Every other framework component that renders btn, icon-btn, cta-btn or expand-btn markup (icon buttons, CTA buttons, menu and listbox buttons, dialogs, notices, pagination, filter and form controls)
  • Fake tabs, fake link and fake menu components in ebayui-core, evo-marko, ebayui-core-react and evo-react, or their replacement (for example a variant prop), as decided by the Marko and React owners
  • Wrappers that render fake-link internally: notices, drawer, panel and fullscreen dialogs, tourtip and snackbar dialog (for example ebay-notice-base, ebay-dialog-base, ebay-snackbar-dialog and their React and evo- equivalents)
  • Snapshots and tests that assert the legacy classes

Skin removal

  • Delete the a.fake-btn* selectors from button.scss, fake-tabs* from tabs.scss, button.fake-link from link.scss and fake-menu* from menu.scss
  • Delete the .fake-link half of the parallel rules in panel-dialog, inline-notice, tourtip, drawer-dialog, section-notice, education-notice, fullscreen-dialog, snackbar-dialog and page-notice
  • Delete the abbreviated half of the parallel button-family selectors in the 26 modules that carry them: button, icon-button, cta-button, calendar, combobox, dialog, drawer-dialog, education-notice, file-preview-card, filter-input, filter-menu, fullscreen-dialog, infotip, lightbox-dialog, listbox-button, menu-button, menu, navigation-menu, number-input, pagination, panel-dialog, phone-input, section-title, textbox, toast-dialog and tourtip
  • Simplify listbox-button--error button:not(.btn--borderless, .button--borderless) to :not(.button--borderless)
  • Delete the legacy stories: button/stories/fake-button/, tabs/stories/fake-tabs/, menu/stories/fake-menu.stories.js, and the fake, disabledFake and legalFake stories in link.stories.js. No other story uses the legacy classes.
  • Rename the fake-link-foreground-* token overrides used by link-button. They kept the old names so existing themes keep working
  • Update packages/skin/src/selectors-api/selectors-api.json: remove the FAKE entries for fake-btn, fake-link and fake-menu, and point .btn, .icon-btn and .cta-btn at the spelled-out names

Docs site

  • Remove the deprecation notices and the legacy sections from the button, icon-button, cta-button, tabs, link and menu CSS pages
  • Update the remaining pages that show the legacy classes: button overview, Marko and React pages, the cta-button Marko and React pages, the menu-button overview, the fake tabs accessibility pattern page, and the "replaces" wording on the button-link, navigation-tabs, navigation-menu and link-button overview pages
  • Add a changeset: @ebay/skin major, listing the removed classes and their replacements

Open question

  • Should the --btn-* custom properties be renamed to --button-* in the same major? #1070 left them unchanged.

Not in scope

  • fake-menu-button, which is a separate component
  • filter-input__clear-btn, an element of filter-input rather than a button-family class
  • packages/skin/docs/archive/ and CHANGELOG.md entries, which are history
Lingua principale
TypeScript
Stelle
53
Fork
58
Merge medio
2g 23h
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di eBay/evo-web

Tutte le issue di eBay/evo-web

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.