obs(api): no metrics on global expiration ZSET size or evictor sweep latency

Aperta
#3,605 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, redis

Direzione di ricerca

Inizia tracciando il passaggio healExpirationIndex e la chiamata a ExpiredItems nell’evictor, quindi individua le convenzioni esistenti per le metriche utilizzate dal codice di storage dell’API. Aggiungi la gauge expiration_index.size proposta durante il passaggio heal e l’istogramma sweep_duration per ogni chiamata a ExpiredItems, quindi verifica che entrambi i segnali vengano emessi con i nomi e le unità documentati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Background

`sandbox:storage:global:expiration` is a single global ZSET shared by every
sandbox across all teams. The evictor calls `ExpiredItems` every 50 ms
(`pollInterval`), which issues a `ZRANGEBYSCORE` against this key on every tick.

Problem

There are currently no metrics to observe:

  1. ZSET cardinality over time — no way to know whether
    `sandbox:storage:global:expiration` is growing unboundedly, shrinking after
    orphan sweeps (#3567), or stable at steady state.
  2. Evictor sweep duration — no way to know how long each
    `ZRANGEBYSCORE + MGET pipeline` takes, or whether sweep latency is
    increasing as the ZSET grows.

Without these two signals it is impossible to:

  • Set an alert before the ZSET grows large enough to cause latency spikes
  • Verify that orphan cleanup (#3567) or future sharding fixes are actually
    reducing cardinality
  • Correlate Redis command latency spikes with evictor tick cost

Production evidence

Observed 2026-08-14 09:00 – 09:30 (Redis big-key scan):

Key Type Memory Elements
`sandbox:storage:global:expiration` zset 3,137,528 B (~3 MB) 22,458
`sandbox:storage:{65380065...}:index` set 588,824 B 9,535
`template:info:{fnqz33l5lhnpqiephgbl}:default` string 12,304 B 1

At `pollInterval = 50 ms` and N API allocations, the evictor issues
20 × N `ZRANGEBYSCORE` calls per second against the 22 k-member ZSET.
This load is currently invisible — there is no metric showing either the
key size trend or the per-sweep cost.

Observability gap

Signal Metric name (proposed) Collection point
ZSET cardinality `api.redis_storage.expiration_index.size` (gauge) Once per heal pass (`healExpirationIndex`, every 5 min)
Evictor sweep duration `api.redis_storage.expiration_index.sweep_duration` (histogram, ms) Per `ExpiredItems` call
Why a gauge for size, not sampled on every evictor tick?

`global:expiration` is already the key being diagnosed as a high-frequency
hot key. Sampling `ZCARD` on every 50 ms evictor tick would add 20 × N
extra Redis calls per second — worsening the problem while observing it.
A single `ZCARD` piggybacked on the existing heal pass (every 5 min,
same cadence as #3604) adds negligible overhead and is sufficient for
capacity planning and alerting.

Why sweep duration matters

`ZRANGEBYSCORE` is O(log N + K) where N = 22,458 and K = batch size (256).
As N grows the per-sweep cost grows. Correlating sweep duration with ZSET
size over time makes the relationship visible before it becomes a latency
incident.

Related

  • #3566 / #3567 — stale team-index entries that may be inflating
    `global:expiration` via orphaned ZSET members
  • #3602 / #3603 — `cjson.decode` blocking Redis event loop on
    `startTransitionScript` (separate hot path)
  • #3604 — per-team index SET size histogram (same observability series)
  • #3591 — RFC: evaluate DragonflyDB as caching backend; ZSET size and
    sweep latency metrics would provide the baseline needed to evaluate
    whether a backend switch is warranted

/cc @jakubno @dobrac @ValentaTomas

Lingua principale
Go
Stelle
1.6k
Fork
438
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di e2b-dev/runtime

Tutte le issue di e2b-dev/runtime

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.