Leaked instances of DuckDBPyType since 2.0

Aperta
#736 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Start by running the pure Python reproducer with DuckDB 2.0, then compare it with the torch and typing.overload scenario. The issue points to DuckDBPyConnection annotations being retained during shutdown and reports leaks in nanobind bindings, but names no source file or test. Done means the reproducer exits without nanobind leak reports.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs triage
What happens?

Since 2.0, our runtimes end with what looks like leaked instances of DuckDBPyType.

nanobind: leaked 27 instances!
 - leaked instance 0x64c7922f1c50 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922f1c10 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e85b0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e86d0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e85d0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8630 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8610 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8730 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922f1c70 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e87d0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8670 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8690 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8810 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922f1c30 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8590 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8770 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e87b0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e85f0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e86f0 of type "_duckdb._sqltypes.DuckDBPyType"
 - leaked instance 0x64c7922e8710 of type "_duckdb._sqltypes.DuckDBPyType"
 - ... skipped remainder
nanobind: leaked 6 types!
 - leaked type "_duckdb._sqltypes.DuckDBPyType"
 - leaked type "_duckdb.DuckDBPyConnection"
 - leaked type "FunctionNullHandling"
 - leaked type "PythonUDFType"
 - leaked type "ExplainType"
 - leaked type "PythonExceptionHandling"
nanobind: leaked 84 functions!
 - leaked function "extract_statements"
 - leaked function "__exit__"
 - leaked function "fetchdf"
 - leaked function "_statement_count"
 - leaked function "install_extension"
 - leaked function "array_type"
 - leaked function ""
 - leaked function "interrupt"
 - leaked function "_own_sources"
 - leaked function "torch"
 - ... skipped remainder
nanobind: this is likely caused by a reference counting issue in the binding code.
See https://nanobind.readthedocs.io/en/latest/refleaks.html
To Reproduce

It seems this is due to interaction with other libs, torch in particular, and typing.overload.

This is a pure Python reproducer

import ctypes

import duckdb

ctypes.pythonapi.Py_IncRef(ctypes.py_object(duckdb.DuckDBPyConnection))

Here is a more realistic scenario.

$ cat lib.py
import typing

import duckdb


class Wrapper:
    def __init__(self, con: duckdb.DuckDBPyConnection): ...


# typing.overload stores the function in typing._overload_registry, which is not
# released at shutdown once torch has been imported.
@typing.overload
def f(x: int) -> None: ...
$ cat repro_torch.py
"""duckdb + torch + a module with a typing.overload and a DuckDBPyConnection annotation."""
import torch  # noqa: F401

import lib  # noqa: F401

Running python repro_torch.py provides the same error message.

OS:

Ubuntu 26

DuckDB Version:

2.0

DuckDB Client:

Python

Hardware:

No response

Full Name:

Jakob Stigenberg

Affiliation:

Qubos Systematic

Did you include all relevant configuration (e.g., CPU architecture, Linux distribution) to reproduce the issue?
  • Yes, I have
Did you include all code required to reproduce the issue?
  • Yes, I have
Did you include all relevant data sets for reproducing the issue?

Not applicable - the reproduction does not require a data set

Lingua principale
Python
Stelle
203
Fork
124
Merge medio
13h 36m
PR unite (30g)
61

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di duckdb/duckdb-python

Tutte le issue di duckdb/duckdb-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.