StickyPartitionAssignor.assign() loops forever when members subscribe to different topics
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 15/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Stack tecnologico
- kafka, python
- Ambito
- distributed-systems
Direzione di ricerca
The hang is in StickyAssignmentExecutor._perform_reassignments in kafka/coordinator/assignors/sticky/sticky_assignor.py, which calls _reassign_partition_to_consumer and PartitionMovements.get_partition_to_be_moved. Run the reproduction script from the issue under faulthandler to confirm it prints 'assignment completed' once fixed. The work is already under way in linked PR #3164, which includes a regression test, so review or extend that PR rather than starting a parallel fix.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
With StickyPartitionAssignor (and, since 3.0, CooperativeStickyAssignor, which uses the same executor), the group leader can hang forever in StickyAssignmentExecutor._perform_reassignments. Members subscribe to different topic sets. The leader never sends SyncGroup, so the whole group stalls.
Reproduced on master (3.1.0.dev), 3.0.11 and 2.3.2. The _reassign_partition_to_consumer code is identical on all three. For context, Apache Kafka's Java client (4.3.1) has the same logic and hangs on the same input.
Reproduction
Every member reports its owned partitions with generation -1, the default when on_assignment has not run yet.
import faulthandler
from kafka.coordinator.assignors.sticky.sticky_assignor import StickyPartitionAssignor
from kafka.protocol.consumer import JoinGroupResponse
from kafka.structs import TopicPartition
PARTITIONS = {'t5': 1, 't8': 12, 't10': 6, 't11': 11, 't12': 24, 't15': 1, 't17': 4}
SUBSCRIPTIONS = {
'c2-p3': ['t11'],
'c5-p2': ['t15', 't10'],
'c8-p0': ['t11', 't10', 't8'],
'c10-p3': ['t10', 't17'],
**{'c11-p%d' % i: ['t5', 't12', 't11'] for i in range(4)},
**{'c12-p%d' % i: ['t5', 't8', 't10'] for i in range(4)},
}
OWNED = {
'c5-p2': [('t10', 0), ('t10', 1)],
'c10-p3': [('t10', 4)],
'c11-p0': [('t11', 4), ('t11', 8)],
'c11-p1': [('t11', 5), ('t11', 9)],
'c11-p2': [('t11', 6), ('t11', 10)],
'c11-p3': [('t11', 3), ('t11', 7)],
'c12-p0': [('t10', 5), ('t8', 0), ('t8', 4), ('t8', 8)],
'c12-p1': [('t8', 1), ('t8', 5), ('t8', 9)],
'c12-p2': [('t10', 2), ('t8', 2), ('t8', 6), ('t8', 10)],
'c12-p3': [('t10', 3), ('t8', 3), ('t8', 7), ('t8', 11)],
}
class Cluster:
def topics(self):
return set(PARTITIONS)
def partitions_for_topic(self, topic):
return set(range(PARTITIONS[topic])) if topic in PARTITIONS else None
def member_metadata(member_id):
assignor = StickyPartitionAssignor()
assignor.member_assignment = [TopicPartition(t, p) for t, p in OWNED.get(member_id, [])]
return assignor.metadata(SUBSCRIPTIONS[member_id])
members = [
JoinGroupResponse.JoinGroupResponseMember(member_id=m, metadata=member_metadata(m))
for m in SUBSCRIPTIONS
]
faulthandler.dump_traceback_later(10, exit=True)
StickyPartitionAssignor().assign(Cluster(), members)
print('assignment completed')
Expected: assignment completed. Actual: the script never finishes. After 10 seconds, faulthandler shows a stack like this:
File ".../kafka/coordinator/assignors/sticky/sticky_assignor.py" in _is_balanced
File ".../kafka/coordinator/assignors/sticky/sticky_assignor.py" in _perform_reassignments
File ".../kafka/coordinator/assignors/sticky/sticky_assignor.py" in balance
File ".../kafka/coordinator/assignors/sticky/sticky_assignor.py" in assign
Root cause
_reassign_partition_to_consumer(partition, new_consumer) asks PartitionMovements.get_partition_to_be_moved(partition, consumer, new_consumer) which partition to move. consumer is the current, overloaded owner.
- Suppose
partitionalready moved from some consumer X toconsumerduring this rebalance. Thenget_partition_to_be_movedreplacesconsumerwith X and looks up the reverse pairnew_consumer -> X. - If a same-topic partition moved
new_consumer -> X, the method returns that partition as the substitute. X owns the substitute, notconsumer. _move_partition(substitute, new_consumer)moves it from X back tonew_consumer.consumerkeeps its load, so_is_balanced()stays false andmodifiedstays true. Thewhile Trueloop then repeats the same choice forever.
Proposed fix
If X owns the substitute, also move partition back to X. The substitute goes X -> new_consumer, then partition goes consumer -> X. Both movement records cancel, so no stickiness cycle remains. The net effect is that one partition leaves consumer, and new_consumer has at least 2 fewer partitions than consumer. The sum of squared assignment sizes therefore strictly decreases, and the loop terminates.
I have a PR with the fix and a regression test.
I used an AI coding assistant (Claude) to investigate this, write the fix, and draft this report.
- Lingua principale
- Python
- Stelle
- 5.9k
- Fork
- 1.5k
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di dpkp/kafka-python
-
Transactional producer's sender loops on AttributeError after a fatal error (2.2 and 2.3 branches)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
dpkp/kafka-python#3161 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 12/100
dpkp/kafka-python#3162 ·
-
Sender: KeyError from muted.remove() while expiring batches orphans the rest; flush() hangs foreverForse già presa @zhechen-cs l’ha presa 8 giorni fa. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 76/100
dpkp/kafka-python#3159 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
dpkp/kafka-python#3122 · 13 commenti ·
-
consumer
Difficoltà 5/5 Più di una settimana Idoneità per principianti 30/100
dpkp/kafka-python#3000 · 2 commenti ·
Tutte le issue di dpkp/kafka-python
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
google-ai-edge/litert-torch#1346 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
geneontology/gocam-py#272 ·
-
pushed_authorization_request sends list authorization_details as a Python reprForse già presa @RaphaelFakhri l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
auth0/auth0-python#903 ·
I maintainer di solito rispondono entro 1 giorno