[Review agent] Require exact test-endpoint reachability and non-copied fixture delta before keeping test-asset findings

Aperta
  • Qualcosa non va?
#70,336 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
testing

Direzione di ricerca

Start with the review-candidate-verifier behavior described in the issue and trace how it evaluates test-asset findings, especially trigger, effect, and oldVsNew. Compare the two named Remote MSAL and Remote Authentication startup fixtures and inspect the active E2E test path. Done means findings require evidence that the exact code is reached with an observable test effect, and copied fixture code is evaluated against its existing baseline.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area-infrastructure
Summary

During Round 2 review of #69721, a reviewer reported and review-candidate-verifier returned KEEP on a string.IsNullOrEmpty(lastCode) && code != lastCode check at src/Components/test/testassets/Components.TestServer/RemoteMsalAuthenticationStartup.cs:77 (/subdir/oidc/token).

Root Cause
  1. Unreached endpoint in the executed test: While RemoteMsalAuthenticationTest hosts TrimmingServerFixture<RemoteMsalAuthenticationStartup>, the active MSAL E2E test only verifies that AuthenticationService.signIn is invoked (__msalSignInCalled) and stops before completing the authorization-code exchange against /subdir/oidc/token. The /subdir/oidc/token branch therefore has no effect on any executed test outcome.
  2. Verbatim copy of pre-existing fixture code (oldVsNew): RemoteMsalAuthenticationStartup.cs:77 is a verbatim copy of existing fixture code in src/Components/test/testassets/Components.TestServer/RemoteAuthenticationStartup.cs:82 on main, which review-candidate-verifier treated as oldVsNew: "n/a" because it appeared in a newly added startup file.
Proposed Fix
  • For findings in testassets/** and test/**, require trigger and effect to prove that an executed test actually reaches the exact route, callback, or branch and that the flaw can affect an observable test outcome (false pass, false failure, flakiness, or masking a product bug under test).
  • When a new test fixture copies helper/endpoint code verbatim from an existing fixture in the repository, require oldVsNew to account for the existing fixture baseline rather than treating the copied helper as a brand-new defect.

Tracked under #70231.

Lingua principale
C#
Stelle
38.5k
Fork
11.6k
Merge medio
3g 1h
PR unite (30g)
289

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di dotnet/aspnetcore

Tutte le issue di dotnet/aspnetcore

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.