Remove the deprecated DoclingServeApiBuilderFactory SPI and related types
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Refactoring
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- java
- Ambito
- backend-api-design, tooling
Direzione di ricerca
The work is in the docling-serve-api and docling-serve-client modules. Start by reviewing the deprecation in issue #696 and the serve-api-provider-migration.md guide. The checklist names specific files to delete (e.g., DoclingServeApiBuilderFactory, LegacyProviderAdapter) and tests to update. 'Done' means all deprecated types are removed, tests pass, and documentation is updated.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
#696 replaced the DoclingServeApiBuilderFactory SPI with DoclingServeApiProvider and deprecated the old types for removal in 0.7.0, keeping a fallback so existing implementations keep working. This issue tracks removing them.
Before removing
- At least one minor release has shipped with the deprecation, so no earlier than 0.8.0.
- Known third-party implementations, such as the Quarkus integration, have moved to
DoclingServeApiProvider.
docling-serve-api
- Delete
ai.docling.serve.api.spi.DoclingServeApiBuilderFactory, and itsusesclause inmodule-info.java. - Delete
DoclingServeApi.DoclingApiBuilderandDoclingServeApi.toBuilder(). - Delete
LegacyProviderAdapterandLegacyProviderAdapterTests. -
DoclingServeApiProviders: remove the legacy fallback, the warning logged when both SPIs are present, and the "(or of the deprecated …)" part of the no-provider message. UpdateDoclingServeApiProvidersTestsandDoclingServeApiTests. - Update the Javadoc of
DoclingServeApi.builder(), which describes the fallback. -
TestApis.StubDoclingServeApi: remove itstoBuilder()override.
docling-serve-client
- Delete
DoclingServeClientBuilderFactoryandDoclingServeClientBuilderFactoryTests. The Jackson detection lives inDoclingServeClient.builder(). -
DoclingServeClientBuilder: dropimplements DoclingApiBuilder<C, B>and the@Overrideannotations of its setters. The setters themselves stay. - Keep
DoclingServeJackson2Client.toBuilder()andDoclingServeJackson3Client.toBuilder(), which return the concrete builder and aren't deprecated, but drop their@Override. - Tests calling
DoclingServeApi.toBuilder()(DoclingServeJackson2ClientTests,DoclingServeJackson3ClientTests,AbstractDoclingServeClientAsyncExecutorTests, which show[removal]warnings today) should useconfig().toBuilder()or the concrete client type. -
AbstractDoclingServeClientConfigTests.toBuilderKeepsEverySettingandtoBuilderKeepsFollowingRedirectscalltoBuilder()on aDoclingServeClient, which resolves to the deprecatedDoclingServeApi.toBuilder()(warnings suppressed). They test the copy constructor, so they must calltoBuilder()on the concrete client type, notconfig().toBuilder().
Both modules
- Remove every
@SuppressWarnings("removal")that only existed for these types, in main and test code.
Docs
-
serve-api-provider-migration.md: remove the Compatibility section on the fallback, or retire the page if it's no longer useful. -
serve-api.md: remove the "Migrating fromDoclingServeApiBuilderFactory" subsection. -
CLAUDE.md: remove the mention of the fallback. -
whats-new.md: add a "Breaking" entry for the removal.
- Lingua principale
- Java
- Stelle
- 136
- Fork
- 26
- Merge medio
- 12h 20m
- PR unite (30g)
- 49
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di docling-project/docling-java
-
docling-project/docling-java#598 · 9 commenti · 1 reazione · 2 assegnatari ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
docling-project/docling-java#557 · 3 commenti ·
-
Increase code coverage Apertaarea:docling-serve documentation good first issue help wanted module:docling-core module:docling-serve-api module:docling-serve-client module:docling-testcontainers
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
docling-project/docling-java#350 · 5 commenti ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
docling-project/docling-java#184 · 5 commenti ·
-
automation enhancement module:version-tester
docling-project/docling-java#134 · 2 commenti · 1 assegnatario ·
Tutte le issue di docling-project/docling-java
Issue simili
-
executions.Query — startDate and timeRange filters are sent with inverted comparison operators Apertaarea/plugin
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
kestra-io/plugin-kestra#190 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
apache/rocketmq-dashboard#5064 ·