Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

preserve_reasoning treats OPENAI_BASE_URL as a first-party OpenAI destination

Aperta
  • Qualcosa non va?
#4,594 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go
Ambito
ai

Direzione di ricerca

Start in pkg/model/provider/openai: compare Client.firstPartyOpenAIDestination, which reads the ModelConfig.BaseURL field, with Client.effectiveBaseURL, which the issue says reasoning replay already uses. Check how preservesResponseState and shouldMergeConsecutiveMessages consume the result. Done means that OPENAI_BASE_URL pointing at a non-OpenAI host disables reasoning replay, and a test covers that case. Confirm the intended behavior with maintainers before changing shouldMergeConsecutiveMessages.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area/providers/openai

Description

pkg/model/provider/openai decides whether a destination is first-party OpenAI in Client.firstPartyOpenAIDestination, which reads ModelConfig.BaseURL. openai.NewClient resolves the effective endpoint differently — base_url, then OPENAI_BASE_URL, then https://api.openai.com/v1 — and stores that result on the embedded config (base.Config.BaseURL). The OpenAI Go SDK also honours OPENAI_BASE_URL on its own.

A model config that names no base_url but points the environment at a local server is therefore classified as first-party OpenAI.

Expected Behavior

provider_opts.preserve_reasoning should not replay encrypted OpenAI reasoning items to an endpoint that is not OpenAI. The first-party determination should consider the endpoint requests actually go to, the way reasoning replay now does in #4485 (Client.effectiveBaseURL).

Actual Behavior

With provider: openai, no base_url, and OPENAI_BASE_URL=http://localhost:8080/v1:

  • firstPartyOpenAIDestination() returns true, so preservesResponseState() is on and reasoning items captured from OpenAI are replayed to the local server.
  • shouldMergeConsecutiveMessages has the same blind spot — it also reads the config field — though that one only affects consecutive-message merging.

Reaching it takes an explicit preserve_reasoning: true, so the blast radius is narrow, but the effect is the opposite of what firstPartyResponses' own comment intends ("Opaque state must not leak to a different vendor's compatible endpoint").

Steps to Reproduce

  1. Configure provider: openai with provider_opts: {preserve_reasoning: true} and no base_url.
  2. Export OPENAI_BASE_URL=http://localhost:8080/v1 against llama.cpp or vLLM.
  3. Run a turn that captures reasoning items, then inspect the next request body.

Additional context

Found while fixing #4363 in #4485. That PR deliberately leaves this path alone: it predates the PR, belongs to the Responses mechanism rather than Chat Completions, and changing it there would widen a review that is already about a different default. Happy to follow up with a PR.

Lingua principale
Go
Stelle
4.4k
Fork
508
Merge medio
7h 52m
PR unite (30g)
237

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di docker/docker-agent

Tutte le issue di docker/docker-agent

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.