feat(webhook): skip automatic reviews by pull request author
I maintainer di solito rispondono entro 1 giorno
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Background
WEBHOOK_EXCLUDED_LABELS=dependencies is meant to skip Dependabot pull requests. Since #1025 the label gates also read the labels from the API when a pull request opens. That only helps when the labels are already on the pull request by the time the opened delivery is handled.
On 2026-10-28, ThrillhouseBot #1276 was opened by Dependabot at 02:16:36. The opened delivery was handled at 02:16:36.9 and found no labels, from the payload or from the API. The labeled deliveries came at 02:16:39. The review ran the model (22,658 input tokens, $0.0038), and the pre-publish label guard then dropped it at 02:16:56 with EXCLUDED_LABEL. Nothing was posted, but the model call was spent, and the review showed as running on the dashboard. #1277, opened 3 seconds later, was skipped up front because its labels were already there.
Label timing can't be made deterministic from our side. The pull request author is in every opened payload.
Change required
- Add
webhook.triggers.excluded-authors(WEBHOOK_EXCLUDED_AUTHORS), a comma-separated list of logins. Matching is case-insensitive and exact. - Skip automatic reviews of pull requests opened by those logins, with a new reason
EXCLUDED_AUTHOR. - Apply it with the draft and branch checks, before any label read, so it costs no API call.
- A manual
/reviewstill overrides it, as it does every trigger filter. - Document it in the README trigger section,
.env.exampleand the generated configuration reference.
Acceptance criteria
- A pull request opened by a login in
WEBHOOK_EXCLUDED_AUTHORSis skipped withEXCLUDED_AUTHORonopened,synchronize,reopenedandready_for_review, whatever its labels. - Matching ignores case and surrounding spaces, and an unset setting skips nobody.
- A manual
/reviewon such a pull request still runs. - Tests cover the above;
./mvnw verifypasses.
- Lingua principale
- Java
- Stelle
- 35
- Fork
- 7
- Merge medio
- 7h 7m
- PR unite (30g)
- 225
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di devops-thiago/ThrillhouseBot
-
documentation enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
devops-thiago/ThrillhouseBot#321 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement java
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
devops-thiago/ThrillhouseBot#1271 ·
I maintainer di solito rispondono entro 1 giorno
-
refactor(review): identify the bot's own read-back text by marker, not English wordingForse già presa @devops-thiago l’ha presa 6 giorni fa. Apertaenhancement java rework
devops-thiago/ThrillhouseBot#1260 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
feat(webhook): translate command replies, learning replies and on-request generator textForse già presa @devops-thiago l’ha presa 6 giorni fa. Apertaenhancement java
devops-thiago/ThrillhouseBot#1259 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
feat(review): translate the review body, check-run summary and round lead-insForse già presa @devops-thiago l’ha presa 6 giorni fa. Apertaenhancement java
devops-thiago/ThrillhouseBot#1258 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di devops-thiago/ThrillhouseBot
Issue simili
-
status: waiting-for-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
spring-projects/spring-framework#37614 ·
I maintainer di solito rispondono entro 1 giorno
-
azure-spring azure-spring-aad Client
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Azure/azure-sdk-for-java#51046 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
helm-knative-apply.sh fails with Helm 4Forse già presa Una pull request collegata a questa issue è aperta o già unita. Apertaarea: triage theme: undefined
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
jhipster/generator-jhipster#35895 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
oracle/graalvm-reachability-metadata#11659 ·
I maintainer di solito rispondono entro 1 giorno