Deprecate `safemode`: confirm destructive operations explicitly, with `prompt=False` at the call
I maintainer di solito rispondono entro 6 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start by reading the implementations of Table.delete(), Table.drop(), Schema.drop(), and the configuration paths named in the issue, then locate their existing tests and delete/drop documentation. Map how safemode supplies the current prompt default before estimating the changes. Done means the acceptance criteria pass across each configuration path, per-call-site warning, non-TTY behavior, docs, and 2.4 release notes.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
dj.config["safemode"] (default True) sets the default prompt for Table.delete(), Table.drop() and Schema.drop(). Setting it to False turns off confirmation for every destructive call in the process, at once and out of sight:
- It's usually switched off for convenience, in a helper, a
datajoint.json, or aDJ_SAFEMODEenvironment variable, and then it applies to code that never asked for it. - A reader of
(Session & key).delete()can't tell whether it will prompt without knowing the process's configuration. - The setting's name says nothing about what it controls.
Getting it wrong costs more than the setting saves: a silent cascade delete or schema drop in the wrong session can't be undone. Skipping confirmation is a decision about one call, so it belongs at that call.
Proposal (2.4)
promptdefaults toTrueinTable.delete(),Table.drop()andSchema.drop(). Passingprompt=Falseis the supported way to skip confirmation. The deprecated setting is honored, with a warning, until 3.0 (item 3).- Deprecate
safemode. Setting it throughdj.config,datajoint.json,DJ_SAFEMODE,config.override()or an instance's config emits aDeprecationWarningnaming the replacement: passprompt=Falseat the call. - Warn where code relied on it. While the deprecated setting is
False, a destructive call made without an explicitpromptwarns once per call site, says to passprompt=False, and behaves as it does today, so existing scripts keep working through 2.x. - No silent hangs. When
prompt=Trueand there's no interactive terminal (stdinisn't a TTY: batch jobs, CI, schedulers), raiseDataJointErrorsaying to passprompt=False, instead of blocking oninput(). - Remove
safemodein 3.0.
Documentation
- The delete and drop docs and the configuration reference: replace
safemodewith explicitprompt=False, and show the pattern for scripts: preview first (for exampledj.Diagram.cascade(T & cond).counts()), then(T & cond).delete(prompt=False). - Say plainly that with
prompt=True, the confirmation is answered while the delete's transaction is open, so the affected rows and tables stay locked until it's answered. In shared databases, preview first and delete withprompt=False. - What's new in 2.4: the deprecation and the migration (search for
safemode, and passprompt=Falsewhere the call should not ask).
Acceptance criteria
- With default configuration,
delete(),drop()andSchema.drop()prompt unless called withprompt=False. - Setting
safemodein any of its forms emits aDeprecationWarning; behavior is otherwise unchanged in 2.x. prompt=Truewithout a TTY raises with a message namingprompt=False; no call blocks on input in a non-interactive process.- Tests cover each configuration path, the per-call-site warning, and the no-TTY error.
- The docs and release notes describe the migration.
- Lingua principale
- Python
- Stelle
- 198
- Fork
- 103
- Merge medio
- 6g 1h
- PR unite (30g)
- 10
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di datajoint/datajoint-python
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
datajoint/datajoint-python#1703 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
datajoint/datajoint-python#1702 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
datajoint/datajoint-python#1701 ·
I maintainer di solito rispondono entro 6 giorni
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
datajoint/datajoint-python#1691 ·
I maintainer di solito rispondono entro 6 giorni
-
dependencies needs-discussion
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
datajoint/datajoint-python#1687 ·
I maintainer di solito rispondono entro 6 giorni
Tutte le issue di datajoint/datajoint-python
Issue simili
-
cognition
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
collabnix/awesome-mcp-lists#433 ·
I maintainer di solito rispondono entro 4 giorni
-
CrossEntropyFilter raises on zero probabilities and single-class resultsForse già presa @NopeCharon l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
Archmonger/ServeStatic#129 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 2 giorni