Deprecate `safemode`: confirm destructive operations explicitly, with `prompt=False` at the call

Aperta
#1,685 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 6 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
mysql, python
Ambito
databases

Direzione di ricerca

Start by reading the implementations of Table.delete(), Table.drop(), Schema.drop(), and the configuration paths named in the issue, then locate their existing tests and delete/drop documentation. Map how safemode supplies the current prompt default before estimating the changes. Done means the acceptance criteria pass across each configuration path, per-call-site warning, non-TTY behavior, docs, and 2.4 release notes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Problem

dj.config["safemode"] (default True) sets the default prompt for Table.delete(), Table.drop() and Schema.drop(). Setting it to False turns off confirmation for every destructive call in the process, at once and out of sight:

  • It's usually switched off for convenience, in a helper, a datajoint.json, or a DJ_SAFEMODE environment variable, and then it applies to code that never asked for it.
  • A reader of (Session & key).delete() can't tell whether it will prompt without knowing the process's configuration.
  • The setting's name says nothing about what it controls.

Getting it wrong costs more than the setting saves: a silent cascade delete or schema drop in the wrong session can't be undone. Skipping confirmation is a decision about one call, so it belongs at that call.

Proposal (2.4)

  1. prompt defaults to True in Table.delete(), Table.drop() and Schema.drop(). Passing prompt=False is the supported way to skip confirmation. The deprecated setting is honored, with a warning, until 3.0 (item 3).
  2. Deprecate safemode. Setting it through dj.config, datajoint.json, DJ_SAFEMODE, config.override() or an instance's config emits a DeprecationWarning naming the replacement: pass prompt=False at the call.
  3. Warn where code relied on it. While the deprecated setting is False, a destructive call made without an explicit prompt warns once per call site, says to pass prompt=False, and behaves as it does today, so existing scripts keep working through 2.x.
  4. No silent hangs. When prompt=True and there's no interactive terminal (stdin isn't a TTY: batch jobs, CI, schedulers), raise DataJointError saying to pass prompt=False, instead of blocking on input().
  5. Remove safemode in 3.0.

Documentation

  • The delete and drop docs and the configuration reference: replace safemode with explicit prompt=False, and show the pattern for scripts: preview first (for example dj.Diagram.cascade(T & cond).counts()), then (T & cond).delete(prompt=False).
  • Say plainly that with prompt=True, the confirmation is answered while the delete's transaction is open, so the affected rows and tables stay locked until it's answered. In shared databases, preview first and delete with prompt=False.
  • What's new in 2.4: the deprecation and the migration (search for safemode, and pass prompt=False where the call should not ask).

Acceptance criteria

  • With default configuration, delete(), drop() and Schema.drop() prompt unless called with prompt=False.
  • Setting safemode in any of its forms emits a DeprecationWarning; behavior is otherwise unchanged in 2.x.
  • prompt=True without a TTY raises with a message naming prompt=False; no call blocks on input in a non-interactive process.
  • Tests cover each configuration path, the per-call-site warning, and the no-TTY error.
  • The docs and release notes describe the migration.
Lingua principale
Python
Stelle
198
Fork
103
Merge medio
6g 1h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di datajoint/datajoint-python

Tutte le issue di datajoint/datajoint-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.