[coverage] Conformance findings: COMPLEX-016

Aperta
  • Qualcosa non va?
#520 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
database

Direzione di ricerca

Start with the coverage PR diff under tests/ and inspect TestNestedTimestampNtzKeepsItsWallClockInArrayMapAndStruct to see how the failure is reproduced. Trace how the SEA/kernel backend renders nested ARRAY, MAP, and STRUCT values and handles each child field's time zone. Done means the test passes in a non-UTC session while nested NTZ values retain 09:15:00.123456 and the zoned timestamp remains 13:15:00.123456Z.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.

Findings

  • COMPLEX-016 [sea]: SEA/kernel backend applies the session-zone conversion to nested TIMESTAMP_NTZ leaves: an NTZ leaf inside ARRAY/MAP/STRUCT renders 05:15:00.123456 instead of the literal's 09:15:00.123456 under America/New_York, while the top-level NTZ column is correct — the container walk forwards one session location to every child instead of resolving the render location per child field
    • failing test: TestNestedTimestampNtzKeepsItsWallClockInArrayMapAndStruct (see the coverage PR diff under tests/)
  • COMPLEX-016: SEA/kernel backend applies the session-zone conversion to nested TIMESTAMP_NTZ leaves: under America/New_York an NTZ leaf inside ARRAY/MAP/STRUCT renders 05:15:00.123456 instead of the literal's 09:15:00.123456, while the top-level NTZ column is rendered correctly — the container walk forwards one session location to every child instead of resolving the render location per child field

Reproduce & Expected

COMPLEX-016 — Verify that under a NON-UTC session time zone a TIMESTAMP_NTZ leaf nested inside an ARRAY element, a MAP value, a STRUCT field, and a STRUCT inside a STRUCT keeps the exact wall clock the literal car…

Reproduce:

  • Set the session time zone through whichever surface the driver exposes -- a
    session parameter on connect (e.g. a timezone session param) or, where no
    such option exists, SET TIME ZONE 'America/New_York' on the same session
    before the test query. A NON-UTC zone is REQUIRED: under a UTC session the
    shifted and unshifted NTZ renderings coincide and the case proves nothing.

Expected (per the shared spec):

  • result has exactly 1 row(s)
  • full assertion contract:
result:
- row_count: 1
- timestamp_wall_clock:
    path: ntz_array[0]
    equals: '2024-06-15 09:15:00.123456'
- timestamp_wall_clock:
    path: ntz_map['a']
    equals: '2024-06-15 09:15:00.123456'
- timestamp_wall_clock:
    path: ts_struct.ntz
    equals: '2024-06-15 09:15:00.123456'
- timestamp_wall_clock:
    path: ts_struct.inner.ntz
    equals: '2024-06-15 09:15:00.123456'
- timestamp_instant:
    path: ts_struct.zoned
    equals: '2024-06-15T13:15:00.123456Z'
- struct_field:
    column: ts_struct
    field: label
    equals: pt

Context

Lingua principale
Go
Stelle
53
Fork
69
Merge medio
2g 12h
PR unite (30g)
16

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di databricks/databricks-sql-go

Tutte le issue di databricks/databricks-sql-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.