Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Exec remediation preview lists files with uncommitted user changes that the apply will not touch

Aperta
  • Qualcosa non va?
#543 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Start by reading the preview and apply paths for exec remediation on the 043 branch, then compare how other handlers represent dirty files as action = "none" with reason user_changes_present (T055d). Trace how previewed paths control whether apply runs the command. Done means the preview excludes user changes while apply still refuses to run when recorded dirty paths conflict; verify against FR-021 and the relevant tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

module-core needs triage quality

On the 043 branch, a previewable exec remediation (effects = "working_tree", offline = true, for example the zizmor fixes) is previewed in a scratch copy of the checkout. The preview lists every file the command would change.

If one of those files has uncommitted user changes, the preview still lists it as a modification. The apply then refuses to run the command and reports the conflict.

Nothing is lost, but the preview overstates what will happen, which violates FR-021 (the preview is what the apply will do). Other handlers already preview such files as action = "none", reason = "user_changes_present" (T055d).

Marking the exec paths none in the plan is not enough on its own: the apply uses the previewed paths to decide whether to run the command, so it would then run and touch the user's file. The fix has to keep that stop. One option is to record the dirty paths on the plan item, mark the step as "will not run", and have the apply re-check the recorded paths before running.

Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).

Lingua principale
Python
Stelle
22
Fork
27
Merge medio
1g 20h
PR unite (30g)
39

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di darnitdevorg/darnit

Tutte le issue di darnitdevorg/darnit

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.