[BUG] Streaming subscribe returns None after a reconnect, making test_streaming_subscribe_receives_published_message flaky
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- grpc, python, redis
- Ambito
- backend, testing-qa
Direzione di ricerca
The bug is in dapr/clients/grpc/subscription.py and dapr/aio/clients/grpc/subscription.py. Start by reading the next_message method and the reconnect_stream logic. Run the failing test with pytest tests/integration/test_pubsub.py -k streaming. Examine the fake sidecar in unit tests to simulate reconnects. The fix must ensure next_message retries after a reconnect and that acks are not lost.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Expected Behavior
tests/integration/test_pubsub.py::test_streaming_subscribe_receives_published_message passes on every run, and Subscription.next_message() returns the next message even when the stream reconnects while it waits.
Actual Behavior
The test fails intermittently. It failed in 6 of the 25 most recent run-tests runs before #1229, on main pushes, merge-queue runs and unrelated PRs (for example runs 35790024069 on main, 35790699043 and 35791305700 in the merge queue). Latest occurrence: #1229, validate (3.14), runtime 1.18.4. Re-running the job on the same commit passed.
WARNING dapr.clients.grpc.subscription:subscription.py:97 Subscription stream error (StatusCode.UNKNOWN): EOF — reconnecting
WARNING dapr.clients.grpc.subscription:subscription.py:124 Can't send message on inactive stream: 'NoneType' object has no attribute 'id'
E AttributeError: 'NoneType' object has no attribute 'data'
tests/integration/test_pubsub.py:113: AttributeError
Sidecar log for the same test:
Subscribing to pubsub 'pubsub' topic 'TOPIC_STREAM' ConnectionID 1
Unsubscribed from pubsub 'pubsub' topic 'TOPIC_STREAM'
error retrieving pending Redis messages: context canceled
Subscribing to pubsub 'pubsub' topic 'TOPIC_STREAM' ConnectionID 2
encountered a non-retriable error while publishing a subscribed message to topic TOPIC_STREAM, err: stream closed
Unsubscribed from pubsub 'pubsub' topic 'TOPIC_STREAM'
The first stream ends with EOF right after it connects. The SDK reconnects, and the runtime is about to deliver the message on connection 2. But next_message() has already returned None to the caller, so the test fails and its finally: subscription.close() closes connection 2 in the middle of that delivery.
Likely cause (SDK side)
next_message()returnsNoneafter a reconnect instead of reading from the new stream. Indapr/clients/grpc/subscription.py#L89-L102, theUNAVAILABLE/UNKNOWN/INTERNALbranch callsreconnect_stream()and falls through, so the method returnsNone. The docstring saysNonemeans "no message received within the timeout", but there is no timeout. A caller that doessub.next_message().data(), or iterates withfor msg in sub, getsNoneor crashes on a transient reconnect. The async client does the same indapr/aio/clients/grpc/subscription.py#L69-L84. It also does not treatINTERNALas retryable, unlike the sync client.- Suspected, not yet confirmed: acks can be lost across a reconnect. The request generator of the old stream (
subscription.py#L52-L56) blocks onself._send_queue.get()and checks_is_stream_active()only afterget()returns. Afterstart()makes the subscription active again, the old generator can take the next ack off the shared queue and yield it into the dead stream. That message is then never acked and is redelivered.
Why the first stream gets EOF right after it connects is a separate question. It may be on the runtime side.
Related: project coverage changes between runs of the same code
The same timing shows up in unit-test coverage. codecov/project uses threshold: 0%, so it fails a PR whenever these lines happen not to run. On #1229, which does not touch client.py, coverage dropped by 7 lines. They are the error and reconnect branches of subscribe_with_handler's stream_messages loop, dapr/clients/grpc/client.py#L641-L654. They ran on main at 03eebe1 and did not run on the PR head 2a11bb8.
test_subscribe_topic_with_handler (tests/clients/test_dapr_grpc_client.py#L411-L463) calls close_fn() and returns without waiting for the streaming thread. close_fn does not join it either. Whether the thread reaches the StreamInactiveError / reconnect branches before the test run ends depends on timing. A deterministic fix would make close_fn join the thread with a timeout, or have the test wait on it. A test that drives each branch on purpose would also help.
Steps to Reproduce the Problem
Run the integration suite repeatedly against runtime 1.18.4 with Redis pub/sub, e.g. uv run pytest tests/integration/test_pubsub.py -k streaming --count 50 (with pytest-repeat), or re-run validate in CI. The failure is timing-dependent.
Suggested fix
- After a successful reconnect,
next_message()should read again from the new stream instead of returningNone, with a bound on retries so a sidecar that keeps failing still surfaces an error. Same for the async client, includingINTERNAL. - Give each stream its own send queue, or stop the old generator on
close(), so acks cannot go to a dead stream. - Add unit tests for both clients against the fake sidecar: a stream that fails with
UNKNOWNonce, then delivers a message.next_message()returns that message, and the ack reaches the new stream. - Keep the integration test as is, since it is what caught this.
- Make the
subscribe_with_handlerunit test deterministic, so thatcodecov/projectstops changing between runs of the same code.
Release Note
RELEASE NOTE: FIX Streaming subscriptions return the next message after a transient reconnect instead of None.
- Lingua principale
- Python
- Stelle
- 272
- Fork
- 152
- Merge medio
- 3g 21h
- PR unite (30g)
- 5
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di dapr/python-sdk
-
dapr-ext-workflow good first issue kind/enhancement P2
Difficoltà 2/5 1-2 giorni Idoneità per principianti 72/100
dapr/python-sdk#853 · 4 commenti ·
-
feature-request
Difficoltà 3/5 1-2 giorni Idoneità per principianti 76/100
dapr/python-sdk#1214 · 1 assegnatario ·
-
dapr-ext-workflow kind/enhancement
Difficoltà 3/5 1-2 giorni Idoneità per principianti 78/100
dapr/python-sdk#1213 ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 76/100
dapr/python-sdk#1200 ·
-
dapr-ext-workflow kind/enhancement
Difficoltà 3/5 1-2 giorni Idoneità per principianti 58/100
dapr/python-sdk#1188 ·
Tutte le issue di dapr/python-sdk
Issue simili
-
area: harness bug status: needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Human-Agent-Society/reef#625 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 80/100
learningequality/kolibri#15351 · 2 commenti ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Name consistency Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
eellak/triplestore#65 · 1 commento ·