LIFEOS/TOOLS imports hooks/lib in 55 files, against the rule in Paths.ts, so those tools cannot load without the hooks tree

Aperta
#2,864 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 5 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
54/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
bun, typescript

Direzione di ricerca

Read LIFEOS/TOOLS/Paths.ts and the imports in DAGrowth.ts, MemoryStatus.ts, and WorkSweep.ts, then inspect hooks/lib/identity.ts, work-config.ts, and lane-rules.ts. Start by checking the reported imports and the --no-hooks install path; verify the proposed move and re-exports work with the reproduction command. Done means TOOLS loads when hooks/ is absent and the Paths.ts dependency rule holds.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

LIFEOS/TOOLS/Paths.ts:8-10 says TOOLS never depends on the hooks tree, because a TOOLS file
importing hooks/lib broke fresh installs between the DeployCore and InstallHooks steps
(#1974, #1968, #1955). On 94bd8f25, 55 files under LIFEOS/TOOLS import from hooks/lib, most
often identity.ts and work-config.ts. With LIFEOS/TOOLS on disk and hooks/ not there,
DAGrowth.ts fails to load. InstallAll.ts:216 offers --no-hooks for a user who declines hooks;
from reading the installer, that leaves the same state for good (not run end to end).

Where
  • LIFEOS/TOOLS/Paths.ts:10 (the rule)
  • LIFEOS/TOOLS/DAGrowth.ts:18, MemoryStatus.ts:27, WorkSweep.ts:43,46 (WorkSweep.ts:239 restates the rule)
  • hooks/lib/work-config.ts and hooks/lib/lane-rules.ts have no importer inside hooks/: 20 and 9 importers outside it
Repro
git grep -lE "from ['\"](\.\./)+hooks/lib/" HEAD -- LifeOS/install/LIFEOS/TOOLS | wc -l    # 55; Paths.ts implies 0
mkdir -p t/LIFEOS && cp -r LifeOS/install/LIFEOS/TOOLS t/LIFEOS/ && cd t && bun LIFEOS/TOOLS/DAGrowth.ts --help
# error: Cannot find module '../../hooks/lib/identity'
Fix

Root cause: the modules TOOLS needs from the hooks tree (identity, work-config, lane-rules) still
live in hooks/lib/, so the rule in Paths.ts holds only for the one resolver that was moved.
A general fix is to move them into LIFEOS/TOOLS/, as was done for Paths.ts, and leave
hooks/lib/* as one-line re-exports: the install-order break cannot come back, and work-config
and lane-rules then sit next to the code that uses them.

Lingua principale
TypeScript
Stelle
19.9k
Fork
2.5k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di danielmiessler/LifeOS

Tutte le issue di danielmiessler/LifeOS

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.