Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Improve Security Boundary for TOFU URLs

Aperta
#657 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
kotlin
Ambito
security

Direzione di ricerca

Start with HubHostTrustValidator and the trustedHubAuthorities storage, then inspect the trust prompt and the "Trusted Hub Hosts" settings screen. Compare the Android design with cryptomator/cryptomator#4309 and determine how existing trusted entries are handled. Done means trust is evaluated for URL combinations rather than independently, with the stored data, prompt, and settings UI consistent.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

misc:hub
Summary

Before Cryptomator connects to unknown URLs (i.e. when unlocking a Hub vault), users have to review and trust these URLs. Currently, such URLs are trusted independently. This means once trusted, these URLs can be mixed (i.e. in a Hub vault config). To increase security, we should extend the trust concept to sets of URLs. If two already-trusted URLs belong to two different sets, they are not trusted in combination.

This is the Android counterpart of cryptomator/cryptomator#4309.

Motivation

The Hub vault config contains two endpoints: authEndpoint and apiBaseUrl. Cryptomator follows the TOFU principle to trust these URLs.

The app-internal trust check (HubHostTrustValidator) validates both against a flat, app-wide trusted-hosts set (trustedHubAuthorities) independently, without confirming that they belong to the same trusted Hub instance. This means a vault config is still accepted when it is edited such that authEndpoint/tokenEndpoint point to an already-trusted Hub host A, but apiBaseUrl points to a different, also already-trusted host B.

Such edits should be made visible to the user, and trust should be requested again for that specific combination.

Considered Alternatives

No response

Anything else?

This affects the stored shape of trustedHubAuthorities, the trust prompt, and the "Trusted Hub Hosts" settings screen. We also have to decide what happens to entries that users already trusted.

This issue was found by Aakarshit Bargotra and they responsibly disclosed it to us.

Note that this is not a vulnerability, because the TOFU principle still holds: Both URLs have to be trusted.

Lingua principale
Kotlin
Stelle
1.2k
Fork
215
Merge medio
12m
PR unite (30g)
5

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cryptomator/android

Tutte le issue di cryptomator/android

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.