Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

render: docker engine discards the network-removal error, so crossplane-render-* networks leak silently

Aperta
  • Qualcosa non va?
#398 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@jcogilvie ci sta già lavorando.

Dal 1/10/2026.

  • #405 di @jcogilvie — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
docker, go
Ambito
infrastructure

Direzione di ricerca

Start with the cleanup returned by Engine.Setup in cmd/crossplane/render/engine_docker.go, then trace its deferred use in xr/cmd.go and op/cmd.go around StopFunctionRuntimes. Reproduce the start-failure or slow-stop cases from #396 and #397, and verify that a failed network removal becomes visible to the caller or command instead of being discarded.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
What happened?

The temporary crossplane-render-* network the docker render engine creates is left behind whenever a
container is still attached to it at cleanup time, and nothing reports the failure.

The cleanup returned by the docker engine's Setup discards its error
(engine_docker.go L106-L108):

cleanup := func() { //nolint:contextcheck // Detached context for cleanup.
	_ = removeRenderNetwork(context.Background(), networkID)
}

In xr/cmd.go and op/cmd.go this cleanup is deferred before StopFunctionRuntimes, so it runs last,
which is the right order. But if any container was leaked (#396, #397), it is still attached to the
network, NetworkRemove fails because the network has active endpoints, and the error is dropped. The
cleanup func signature (func()) means callers can't learn about it either.

Expected: a network-removal failure is reported (returned to, or at least logged visibly for, the caller),
so it doesn't vanish silently.

This affects library consumers that call Engine.Setup as well as the render commands.

How can we reproduce it?

Run either the start-failure reproduction from #396 or the slow-stop reproduction from #397. The run's network is still
there afterwards:

$ docker network ls --filter name=crossplane-render- --format '{{.CreatedAt}} {{.Name}}'
2026-09-30 18:55:29 -0400 EDT crossplane-render-b2rvl4jh

Once the leaked containers are removed by hand, docker network rm on the same network succeeds.

In our testing, every run that leaked a container also leaked its network (the start-failure run, all 7
slow-stop trials, and both interrupted runs from #400); each network's creation time matched its run.
Runs where every container was removed left no network. That points to the attached containers as what
makes network removal fail.

Possible fixes:

  • Return or log the removeRenderNetwork error instead of discarding it. Changing the Setup cleanup's type
    from func() to func() error would let callers handle it, though that changes the Engine interface.
  • Optionally, before removing the network, disconnect or force-remove any render-owned containers still
    attached to it. That would be much safer once render-created resources are labelled (#401), because a
    user-supplied --crossplane-docker-network may have unrelated containers on it.
What environment did it happen in?
  • Crossplane CLI version: built from main @ 29316fea54f2ede9d2c039d9c54f0c29cbad4b65
  • Platform (e.g., linux/amd64): darwin/arm64, Docker Engine 29.5.3 (Rancher Desktop)
  • Crossplane version (if applicable): render engine image xpkg.crossplane.io/crossplane/crossplane:stable
Lingua principale
Go
Stelle
19
Fork
33
Merge medio
3g 4h
PR unite (30g)
40

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di crossplane/cli

Tutte le issue di crossplane/cli

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.