Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

fix(mcp): refuse delete_node in Face selection mode like the native path

Aperta
  • Qualcosa non va?
#83 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
api, desktop

Direzione di ricerca

Read AGENTS.md first for the shared typed operation guard rules. The native refusal is in native_operation in src/app.rs around line 243, and the remote path goes through remote_operation_guarded into apply_operation_guarded, which has no Face-mode check for Operation::Delete. Move or share the check so both paths return the same typed error, then add a regression test that SDK delete_node in Face mode leaves the scene, selection and history unchanged. Done means that test passes, the guard matrix snapshot from #81 has Face-mode Delete cells, and the MCP docs state the refusal.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area/mcp area/selection type/bug

Problem

Native Delete is refused in Face selection mode, but the MCP delete_node path is not, so a remote client can delete the whole object while the editor is in Face mode. Native UI and MCP must share the same typed operation guards (AGENTS.md).

Current behavior

  • Native: native_operation refuses Delete in Face mode before the guarded pipeline (src/app.rs, around line 243).
  • Remote: remote_operation_guarded -> apply_operation_guarded has no Face-mode check for Operation::Delete, so the deletion succeeds.

Found by the safety-net review of #81 (guard matrix work for #78).

Expected

Delete in Face mode is refused identically for native and remote callers with the same typed error, with the scene unchanged, until component (face) deletion is implemented.

Acceptance

  • The refusal lives in the shared guarded path (or both paths call one check), not only in native_operation.
  • Regression test that fails before the fix: SDK delete_node in Face mode returns the typed refusal and leaves the scene, selection and history unchanged; native path test kept.
  • Guard matrix snapshot (#81) updated with the Face-mode Delete cells.
  • MCP docs state the refusal.
Lingua principale
Rust
Stelle
4
Fork
2
Merge medio
6h 23m
PR unite (30g)
17

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cristim/AztecCraft

Tutte le issue di cristim/AztecCraft

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.