Common Lisp `rt` suites (testing/*.lisp + .testvec) and Clojure `lein test-all` project.clj aliases are not recognised

Aperta
  • Qualcosa non va?
#265 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
devtools

Direzione di ricerca

The two false negatives come from ecosystem detection in project_validator/ecosystems/common_lisp.py (the path regex near line 50, the contains regex at lines 52-53, and _RUNS_TESTS at lines 57-58) and project_validator/ecosystems/clojure.py (lines 76-80, which match only literal lein test invocations). Check facts/roles.py:27 for how testing is already treated as a test directory. Done means the two repro cases (testing/t.lisp with rtest:deftest and a project.clj alias that expands to test) report PASS, with existing tests still passing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

ironclad: 137 .testvec vectors + rtest:deftest forms under testing/, run by every job → FAIL "no tests found (FiveAM, Parachute, Rove or Prove tests (tests/*.lisp))". compojure: CI runs lein test-all, a project.clj alias for lein with-profile … test → WARN "no CI runs clojure -M:test, lein test …". Aliases in project.clj (and deps.edn) are readable.

Evidence from the corpus audit

sharplispers/ironclad / tests-run
  • kind: FALSE_NEGATIVE
  • actual: FAIL "Common Lisp: no tests found (FiveAM, Parachute, Rove or Prove tests (tests/*.lisp))"
  • expected: PASS: an rt test suite in testing/ (137 .testvec vectors + rtest:deftest forms) run by every CI job.
  • evidence: ironclad.asd:249-256: (defsystem "ironclad/tests" :depends-on ("ironclad" "rt") ... :perform (test-op (o s) (or (funcall (intern "DO-TESTS" (find-package "RTEST"))) ...)) :components ((:module "testing" ...;
    testing/test-vectors/ironclad.lisp:6: (rtest:deftest quotationp.1; .github/workflows/ci.yml:43:
    run: ros -e '...' -e '(ql:quickload "ironclad/tests")' -e '(unless (rt:do-tests) (uiop:quit -1))'.
    project_validator/ecosystems/common_lisp.py:50: path=re.compile(r"(?:^|/)(?:tests?|t)/.+\.lisp$|-tests?\.lisp$")
    excludes testing/ (although facts/roles.py:27 already treats testing as a test directory), and the
    contains regex (lines 52-53) knows (deftest/(rove:deftest but not (rtest:deftest/(rt:deftest; _RUNS_TESTS
    (lines 57-58) does not know (rt:do-tests).
  • repro: x.asd with (defsystem "x/tests" :depends-on ("rt") ...), testing/t.lisp containing (rtest:deftest a 1 1),
    workflow run: ros -e '(ql:quickload "x/tests")' -e '(unless (rt:do-tests) (uiop:quit -1))'
  • confidence: high
weavejester/compojure / tests-run
  • kind: FALSE_NEGATIVE
  • actual: WARN "tests found in 5 file(s), but no CI configuration runs clojure -M:test (or -X:test, lein test, kaocha, bb test)"
  • expected: PASS: CI runs lein test-all, a project.clj alias that runs lein with-profile ... test.
  • evidence: .github/workflows/test.yml:29: run: lein test-all; project.clj:17-18: :aliases {"test-all" ["with-profile" "default:+1.10:+1.11:+1.12" "test"]}. project_validator/ecosystems/clojure.py:76-80 matches only
    literal ("lein","test") etc.; Leiningen :aliases are not resolved (the BEAM profile resolves Mix aliases, the
    JS profile package scripts; docs/ecosystems/clojure.md documents only CLI aliases). lein with-profile X test
    (the expansion) is not matched either.
  • repro: project.clj with :aliases {"test-all" ["with-profile" "+a" "test"]}, test/x_test.clj with deftest,
    workflow run: lein test-all
  • confidence: high

Found by the regression-corpus audit (235 real repositories, one or more per ecosystem profile; corpus and expected results in corpus/). Evidence is quoted from the audited checkouts at the commits pinned in corpus/projects.toml; <checkouts>/<owner>__<repo> is such a checkout.

🤖 Generated with Claude Code

https://claude.ai/code/session_01ByTXNqDWdM7HzezrFtEvQt

Lingua principale
Python
Stelle
4
Fork
1
Merge medio
10h 41m
PR unite (30g)
79

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cpp-best-practices/project_validator

Tutte le issue di cpp-best-practices/project_validator

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.