Leaderboard page: name the people who qualify but haven't linked their GitHub yet
I maintainer di solito rispondono entro 1 giorno
@varun-pahuja ci sta già lavorando.
Dal 21/10/2026.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 76/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
- Ambito
- backend-api-design, frontend
Direzione di ricerca
Read handleLeaderboardPage in src/index.ts, linkedMembers in src/links.ts, and the page and message helpers in src/page.ts and src/messages.ts; compare the existing linking tests in test/page.test.ts and route tests in test/index.test.ts. Follow the acceptance criteria for qualifying rows, program end, lookup failures, escaping, and phone width. Done means the line appears only for qualifying unlinked people, the page remains available after lookup errors, and the requested tests pass.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
We contact the winners by Discord DM, so we need to know which Discord account goes with each GitHub login, and we only know that once the person has run /link (src/links.ts). The leaderboard page has one general line about it near the bottom (src/page.ts, line 204), but it doesn't say who still has to do it. Two of the six people who qualify on the October board haven't linked yet.
The final results post in Discord already names the winners who haven't linked (leaderboardMessage in src/messages.ts, lines 161 to 165). The page should do the same while there's still time.
What to do
- In
handleLeaderboardPage(src/index.ts, line 105), when linking is on (linkingEnabled(env)), check who has linked withlinkedMembers(src/links.ts, line 46). Only pass the logins of the rows that qualify: it's one KV read per login, and there's no reason to read the whole board. - Pass the result to
leaderboardPageand add one line above the board that names the people who qualify but haven't linked, for example: "octocat and hubot qualify but haven't linked their GitHub yet. Join the Discord and run /link there, so we can reach you if you win." Link each name to the person's GitHub profile like the rows do, and "Join the Discord" tolinks.discord. - Once the program has ended, name only the winners (
row.winner), like the final results post does. - Add nothing when linking is off, when nobody qualifies yet, or when everyone who qualifies has linked.
- If the lookup fails, log it and show the page without the line. Right now any error in
handleLeaderboardPageturns the whole page into a 503 (line 139). - Chips are hidden on narrow screens (
src/page.ts, line 125), so don't make it a chip. It has to show on a phone. - Leave the JSON (
/leaderboard/{id}.json) as it is.
Where to look
src/index.ts:handleLeaderboardPage(line 105), and the final results post, which callslinkedMembers(line 412)src/links.ts:linkedMembers(line 46) gives a map from the lowercased login to the Discord id, for the logins that are linkedsrc/page.ts:leaderboardPage(line 140), the status line (line 197) and the Discord note (line 204)src/messages.ts:joinNames(line 86) and the sentence about unlinked winners (line 164)test/page.test.ts: the linking tests (line 90), andtest/index.test.tsfor the route (makeEnvintest/helpers.tscomes with an in-memory KV)
#4 changes the rows of the same page, so keep this to the new line and the lookup.
Acceptance criteria
- With linking on, the line names everyone who qualifies and hasn't linked, in board order, with links to their GitHub profiles, and nobody who has linked
- After the end, only winners who haven't linked are named
- No line when linking is off, when nobody qualifies, or when everyone who qualifies has linked
- Only qualifying rows are looked up, and a failed lookup still shows the page, without the line
- Logins are escaped, since they come from GitHub
- The line shows at phone width
- Tests for the cases above, for the page and for the route
- A screenshot of the page with the line, in the PR
-
npm run typecheckandnpm testpass
Want to work on this? Comment below and I'll assign it to you. Please take one issue at a time, branch off develop, and open your PR against develop with Closes #55 in the description.
- Lingua principale
- TypeScript
- Stelle
- 0
- Fork
- 1
- Merge medio
- 12h 22m
- PR unite (30g)
- 36
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di codercops/discord-bot
-
Merged PR shoutout: ask people who haven't linked their GitHub to run /linkForse già presa @princecherry9905 l’ha presa oggi. Apertaenhancement good first issue hacktoberfest
codercops/discord-bot#66 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Merged PR shoutout misses the count when the program label is added after the mergeForse già presa @An16og l’ha presa oggi. Apertabug hacktoberfest help wanted
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
codercops/discord-bot#59 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
hacktoberfest
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 15/100
codercops/discord-bot#15 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di codercops/discord-bot
Issue simili
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
endora-commerce/endora-commerce#397 ·
I maintainer di solito rispondono entro 1 giorno
-
level/task
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
wazuh/wazuh-dashboard-plugins#9472 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
I maintainer di solito rispondono entro 1 giorno
-
ready-for-agent
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
xavxyz/bei-shan-lin-shui#57 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
opennextjs/opennextjs-cloudflare#1461 ·
I maintainer di solito rispondono entro 1 giorno