Should a Mock inside a synctest test follow synctest's clock?

Aperta
  • Qualcosa non va?
#35 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
8/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
testing-qa

Direzione di ricerca

This is a design question, not a patch: the issue asks whether a *Mock inside a synctest test should follow synctest's fake clock or keep its own time. Read the mock clock implementation and the NewReal() clock in the quartz package, along with the prototype behaviour described in the issue (Advance, timers, ctx.Deadline). Done means a maintainer-agreed answer to the design question and the README wording that follows from it, which needs input from @spikecurtis first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Go 1.25 made testing/synctest stable. In a synctest test, the time package runs on a fake clock that jumps forward whenever every goroutine in the test is blocked. That overlaps with what quartz does, so the README needs to say when to use which (#34). Before writing that, we want to agree on one design question:

Should a *Mock created inside a synctest test follow synctest's fake clock, or keep its own time as it does today?

Today the two clocks are independent. Calling time.Sleep(time.Hour) inside the test does not move the mock, and mClock.Advance(time.Hour) does not move time.Now(). quartz.NewReal() already follows synctest's clock, because it calls the time package.

We prototyped a mock that follows synctest's clock: timers are real time timers, and Advance(d) is time.Sleep(d) followed by synctest.Wait(). Compared with today's *Mock:

  • Better: ctx.Deadline() agrees with time.Now(), and Advance can move past several timers at once, firing them in order. Today Advance stops at the next timer.
  • Worse, time moves without Advance: a test that forgot to call Advance and then waited for the code to start its next timer still passed, because synctest moved time forward by 10s on its own. Today's mock fails that test.
  • Worse, real I/O: a 5s timeout never fired during a real TCP read. Advance(5s) blocked until the read finished, because synctest does not move time while a goroutine waits on the network. Today's mock canceled the read after 67µs.

We also tried keeping the mock's own timers but sleeping the same amount on every Advance, so both clocks stay equal. They drift apart as soon as code in the test sleeps on its own. After a 1-minute time.Sleep in library code, the mock was 1 minute behind.

The one thing a synctest-following mock adds over NewReal() is traps.

Our recommendation: keep the *Mock independent. The README would say: use synctest with NewReal() when the whole test can run inside synctest, and use a *Mock when it does real I/O or needs to control exactly when time moves. If traps turn out to be wanted with synctest, a separate option is to add traps to the real clock rather than changing the mock.

@spikecurtis, does that match your view?

🤖 This issue was created with the help of Coder Agents.

Lingua principale
Go
Stelle
273
Fork
9
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di coder/quartz

Tutte le issue di coder/quartz

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.