🤖 CoderWorkspaceClaim Share mode: claim reasons reveal facts about named Coder users

Aperta
  • Qualcosa non va?
#449 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, kubernetes
Ambito
authorization, security

Direzione di ricerca

Start with the claim reasons ShareUserNotFound and ShareUserNotEligible and the messages that claim status shows for them, then trace where the operator sets them. Decide between the two options in the issue: a single generic refusal with details moved to Events or the operator log, or keeping the reasons and documenting the exposure in the pool how-to. The maintainers must choose first, since the work depends on that decision.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

A Share claim (#446) shows why its user cannot get the share. The reasons ShareUserNotFound and ShareUserNotEligible and their messages tell the claimant whether a named Coder user exists, whether the user is active, and whether the user is a member of the template's organization and of a group in the owner's shareGroupIDs. So anyone who can create and read claims in a namespace with a Share pool can learn these facts about Coder users, even without access to Coder's user directory.

Found by the Codex security review of #446 (round 4, P3): https://github.com/coder/coder-k8s/pull/446#discussion_r4433728850

Impact

Only principals that the namespace's RBAC lets create and read claims see the reasons, and only for the users they name. Share mode is an admin opt-in per owner. No data loss. Plan 6.4 of #153 defines these reasons on purpose so that a claimant can see why a claim waits, and the refusal names a group that Coder would not let the operator read, so that an admin can fix the pool.

Options

  1. Give the claim one generic refusal reason, and keep the details where only admins see them (for example Events in the operator's namespace, or the operator log).
  2. Keep the detailed reasons and add a docs note in the pool how-to: claim status shows whether a named Coder user exists, is active, and is in the organization and a listed group, so grant claim create and read only to people who can know that.

Refs #153.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh

Lingua principale
Go
Stelle
5
Fork
3
Merge medio
1h 50m
PR unite (30g)
160

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di coder/coder-k8s

Tutte le issue di coder/coder-k8s

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.