Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Remove unused unsubscribed column from members

Chiusa
  • Qualcosa non va?
#3,007 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@mroderick ci sta già lavorando.

Dal 12/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Problem

The members.unsubscribed boolean column is dead and should be dropped. Nothing reads or writes it. It survives in db/schema.rb and in production data only.

Git history shows when it died:

  • 2013-10-21 (86bae547): migration 20131021040356_add_unsubscribed_to_member.rb added the nullable boolean, MembersController#unsubscribe set it to true, and the invitation email carried the unsubscribe link.
  • 2014-03-29 (bd0772a2): default_scope -> { where(unsubscribed: [false, nil]) } became the only read.
  • 2014-06-22 (59df6c1c): that default scope was removed. Nothing has read the column since.
  • 2014-08-24 (0cdd988a): the unsubscribe action became a signed-token redirect to the subscriptions page. The write went with it. Nothing has written the column since.

Unsubscribing today runs through soft-deleted subscriptions (Discard, tombstones per #2920); the newsletter opt-in is tracked in opt_in_newsletter_at. The originating migration was deleted with the pre-2026 migration purge (fd7e972f).

Production data

The column still holds the 2013-2014 clicks (snapshot 2026-10-12): 84 true, 6 false, 29,576 NULL. All 90 non-null values belong to members created between 2013-10-21 and 2014-07-01. Of the 84 flagged members, 11 hold active subscriptions today and have received mail for years regardless of the flag, and 2 have opted into the newsletter since.

Recommendation: drop the column without changing any subscription state. The flag has been inert for over 12 years; acting on it now would apply decade-old intent over current state, including over the 2 later opt-ins. The counts above are the last trace of the feature.

Why the two-step removal is load-bearing

Production runs with Heroku preboot: the release phase runs migrations before new dynos boot, and old dynos keep serving against the new schema during the switch. Old releases build their member SELECT list from their schema cache and name every column explicitly (SELECT "members"."id", ..., "members"."unsubscribed", ...). Dropping the column while old dynos serve would fail every member query on them with PG::UndefinedColumn. Writes are not affected: partial_inserts keeps the nullable, default-less column out of INSERTs.

So the removal stays as proposed:

  1. Add unsubscribed to self.ignored_columns on Member and deploy. The column then drops out of the new release's SELECT list and out of the model's attribute methods.
  2. In a separate deploy, wrap remove_column :members, :unsubscribed in safety_assured. strong_migrations 2.8 prescribes exactly this sequence.
Verification notes
  • grep and ast-grep across app, lib, config, spec, db: no code reference to the column. Matches are comments, locale strings, view prose and spec variable names only.
  • No migration in db/migrate/ references it. The originating migration was deleted in fd7e972f.
  • No database views or triggers reference the column.
  • The codebar auth app does not reference the column.
  • Member.all.to_sql on master names members.unsubscribed in the SELECT list; with ignored_columns set it does not.
Lingua principale
Ruby
Stelle
105
Fork
206
Merge medio
19h 48m
PR unite (30g)
83

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codebar/planner

Tutte le issue di codebar/planner

Issue simili

Altre issue su Ruby

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.