Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Cleanup: identify and fix users affected by the id_token email-claim regression

Aperta
  • Qualcosa non va?
#2,984 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
30/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rails, ruby
Ambito
authentication, database

Direzione di ricerca

Start by reading the issue's described fallback in lib/omniauth/strategies/codebar.rb and the listed cleanup queries; run the scans only after codebar/auth#83 is deployed. Keep emails and auth IDs in private ops notes, reporting counts and member IDs in the issue. Done means affected records are safely merged or re-keyed, members 31450 and 31452 are gone, no matching garbage records remain, and a magic-link sign-in resolves to the correct member.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The fix in codebar/auth#87 (PR codebar/auth#83) makes every id_token carry the user-record email and name claims. After it merges and deploys, the data damage from the regression still needs cleanup.

While the regression was live (auth release v64, 2026-10-02 10:01-16:34 UTC), a magic-link sign-in produced an id_token without an email claim. The codebar OmniAuth strategy fell back to sub (email = payload['email'] || payload['sub'] in lib/omniauth/strategies/codebar.rb) and created a planner member whose email and name were the better-auth user id: an empty account with no subscriptions or roles. Two such members are known: 31450 and 31452. Their users were dropped into the new-member flow as if they had never signed up. The rollback (v65) restored correct behaviour immediately: member 17284 has confirmed that sign-in works normally again. The window is therefore closed at 2026-10-02 16:34 UTC, and what remains is data cleanup.

1. Identify any affected users

  • Find planner members whose email is a better-auth user id: members created in the window whose email matches a 32-character opaque id, or whose email equals an auth user id directly.
  • Cross-check auth_service rows with provider codebar created in the window: a row whose uid has that same 32-character shape points at a garbage member.
  • detect_duplicate_members does not find these: the garbage member's email and name share nothing with the real member. Use the queries above, not the duplicate detector.
  • Keep the resulting user list out of this issue (emails and ids go in the private ops notes); report only counts and member ids here. Expected result: exactly 31450 and 31452 — earlier dump scans found no members of this shape before v64. The scan's real job is to confirm that and to catch anything the users created while stuck in the new-member flow.

2. Fix the identified users

For each affected user:

  1. If a real member exists (the usual case): merge anything the garbage member picked up (the user may have completed the new-member flow) into the real member, then delete the garbage member and its auth_service row. 17284 is confirmed already: their real member is intact and in use, so only the garbage member (31452) goes.
  2. If no real member exists (a genuinely new user who signed up during the window): re-key the member to the user's real email and name instead of deleting it.
  3. Confirm the user's next magic-link sign-in resolves to the same member. GitHub sign-ins already resolve via github_id and are unaffected.

Verification before closing

  • One magic-link sign-in resolves the real member on the fixed build (1.7.7 + explicit claims — different code path from the rollback that 17284 confirmed; member 17284 is the known case).
  • No member has an email equal to a better-auth user id, and no auth_service row has a codebar uid of that shape.
  • Members 31450 and 31452 are gone.

Timing: run this after codebar/auth#83 is deployed. Sign-ins after the fix can no longer create members of this shape.

Lingua principale
Ruby
Stelle
105
Fork
206
Merge medio
1g 3h
PR unite (30g)
74

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codebar/planner

Tutte le issue di codebar/planner

Issue simili

Altre issue su Ruby

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.