crew: one-click GitHub App setup (manifest flow, prefilled), pick which orgs/repos it can access

Aperta
#528 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, rust

Direzione di ricerca

Start by reading the GitHub integration under Atlas Crew → Settings → GitHub and trace how the current gh login credentials are stored and used. Then map the manifest conversion, webhook setup, installation token, and app installation flows described in the issue to the relevant entry points. Done means users can create and install a scoped GitHub App from Atlas while the existing login remains available.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: desktop status: needs-triage type: feature

Problem

Today a crew server reaches GitHub through gh signed in as the crew user (device-code login in Atlas Crew → Settings → GitHub). That is a personal login: the crewmates act as that user, with that user's reach, and choosing which organizations and repos the crew may touch means setting things up by hand on GitHub. Creating a GitHub App by hand for the crew (name, permissions, events, webhook URL, keys) is long and easy to get wrong.

Suggestion: one-click GitHub App, created from Atlas

Use GitHub's App manifest flow so the app is created with everything already filled in:

  1. In Atlas Crew → Settings → GitHub, a Create GitHub App button, with a choice of owner: my account or one of my organizations.
  2. Atlas opens GitHub's "create app" page with a manifest that already has the name (e.g. atlas-crew-<server>), the permissions the crew features need (contents, pull requests, issues, checks/actions read, metadata), the events the GitHub automations use (issue comments, issues, pull requests, PR review comments, check runs/workflow runs, releases) and the webhook URL of the crew server's hook server when it is reachable. The user only confirms on GitHub.
  3. GitHub sends back the code; Atlas converts it (POST /app-manifests/{code}/conversions) and stores the app id, private key and webhook secret on the crew server, as secrets of the crew (never in a repo, never sent to CodeAtlas).
  4. Atlas then opens the app's Install page, where the user picks which organizations and which repos the app gets access to. Changing that later is one link from Atlas Settings.
  5. Crewmates use short-lived installation tokens from the app for git and the GitHub API, instead of a personal gh login.

Why

  • One click instead of a manual app setup.
  • Access is scoped by GitHub itself: the owner picks orgs and repos, and can revoke the app at any time.
  • Commits, comments and PRs come from a bot identity (atlas-crew-<server>[bot]), not from the owner's personal account.
  • With the webhook set, GitHub automations can fire on events instead of polling every 2 minutes.

The current gh login can stay as the simple option.

Lingua principale
Rust
Stelle
3
Fork
1
Merge medio
9h 51m
PR unite (30g)
310

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codeatlasdev/atlas

Tutte le issue di codeatlasdev/atlas

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.