Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] owners.ts: 13 behavioural mutants survive the suite, incl. a shared group cache key that gives every team the first team's members

Chiusa
  • Qualcosa non va?
#574 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Una pull request collegata è già stata integrata.

  • #575 di @hivecommons-hive — chiusa senza merge
  • #588 di @mrbobbytables — integrata

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, typescript
Ambito
testing

Direzione di ricerca

The issue names the exact mutants by line in src/utils/owners.ts and prescribes the deliverable: a new __tests__/utils/ownersGuards.test.ts exercising expandGroups, parseOwners, loadOwnersTree, repoHasOwners and branchHasOwners with no src/ changes. Start by reading #572's harness notes, then reproduce with npx stryker run --mutate src/utils/owners.ts. Done is when the 13 listed mutants are killed (15 → 2 survivors, ~98.5%). Note: an open PR #575 already targets this issue, so it is effectively claimed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality needs-kind stage/040-covered-by-pr testing

Finding

Running the bounded Stryker harness proposed in #572 against src/utils/owners.ts (npx stryker run --mutate src/utils/owners.ts --force, Stryker 10.0.0, Vitest 5.0.4, main @ e3119ad) gives 332 mutants: 304 killed, 13 timed out, 15 survived (95.48%). Unit coverage of the file is 100/100/100/100 (npm run test:coverage @ e3119ad), so these are assertion gaps, not coverage gaps; the bundle suite runs the committed dist/index.js and cannot see a mutation of src/.

Thirteen of the survivors are behavioural (each applied by hand at its reported span and re-run to confirm):

Site Mutant What goes unpinned
owners.ts:151 memoized(groupCache, \${owner}/${slug}`, …)` key → '' Every team shares one cache entry: the second @org/team in an OWNERS set resolves to the first team's members. No test expands two distinct teams in one run.
owners.ts:99 parseGroup regex leading ^ removed alice@org/team is read as a group of org and a team is fetched for it
owners.ts:52 options !== null → true a bare options: key (YAML null) throws TypeError instead of meaning "no options"
owners.ts:278 file.content === undefined → false a blob with an encoding but no content fails with a Buffer TypeError, not "invalid OWNERS file returned from GitHub API for …" (only encoding-less blobs are tested)
owners.ts:468 repository?.default_branch ?. → . a payload with no repository at all throws instead of asking repos.get (every test payload carries a repository object)
owners.ts:482 isNotFound (6 mutants) guards → true / &&→|| a string or null rejection from git.getTree is never exercised; several arms would throw TypeError: Cannot use 'in' operator instead of the listing error
owners.ts:447 entry.path !== undefined → true a tree entry without a path throws inside probeBranchOwners (the same guard in loadOwnersTree is pinned)
owners.ts:398 hasOwnersCache key ${owner}/${repo} → '' repoHasOwners answers a second repository from the first
owners.ts:139 other-organization warning text → '' the only user-facing hint that a group was ignored

Not counted: owners.ts:161 (warning text, asserted exactly by held #564) and owners.ts:317 (core.debug text, equivalent by the review standard #572 documents).

Recommendation

Pin each contract in one new unit file, __tests__/utils/ownersGuards.test.ts, with direct expandGroups/parseOwners/loadOwnersTree/repoHasOwners/branchHasOwners calls (no src/ change). Re-running the harness with that file: 15 → 2 survivors (98.49%), both the exclusions above.

  • __tests__/utils/ownersGuards.test.ts pins the 13 behavioural mutants listed above

Priority

  • Impact: medium (the group-cache key is a real bug class for repositories that list two teams; the rest are guard contracts)
  • Effort: low

Refs #554 ("Strengthen assertions and the test harness" — a consumer of the mutation harness, not a tracker box of its own).

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e3119ad

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
24
Merge medio
1g 18h
PR unite (30g)
211

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.