Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] blunderbuss never excludes an already-assigned user in the bundle suite (pullRequestOwners.ts:96 has 0 e2e hits)

Chiusa
  • Qualcosa non va?
#402 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Una pull request collegata è già stata integrata.

  • #403 di @hivecommons-hive — integrata

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
20/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
typescript
Ambito
testing

Direzione di ricerca

The mapping is at src/utils/pullRequestOwners.ts:96 and its consumer is the excluded set in src/plugins/blunderbuss.ts:165. Read the existing unit case in __tests__/plugins/blunderbuss.test.ts and the bundle harness in __tests__/bundle/blunderbussSettings.test.ts before adding an assignees case. Linked pull request #403 is already open against this issue, so check its status before starting. Done means the bundle test passes with one mixed-case assignee excluded, and the both-assigned case logs no reviewer candidates.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

loadPullRequestOwners lowercases a pull request's assignees (src/utils/pullRequestOwners.ts:96) and blunderbuss adds them to its exclusion set so an assignee is never asked to review their own assignment (src/plugins/blunderbuss.ts:165). No bundle test ever gives the fake GitHub a pull request with a non-empty assignees array, so the mapping callback and the exclusion it feeds have 0 hits through dist/index.js.

Evidence (main @ 20d49e7, Node v26.10.0):

  • Unit: npx vitest run --coverage → 100 % lines; __tests__/plugins/blunderbuss.test.ts:176 ("skips already requested reviewers and assignees") reaches it with an in-process MSW handler.
  • End-to-end: npm run test:coverage:e2e on a scratch branch = origin/main + the heads of the 12 open hold-gated bundle PRs (#298, #314, #333, #345, #347, #378, #381, #383, #385, #395, #397, #401; 57 files / 414 tests pass) → 98.05 % lines of src/. pullRequestOwners.ts:96 has 0 hits (coverage-final.json: fnMap entry at line 96, f = 0). Lines 55-56 (resetPullRequestOwnersCache, test-only export) are the only other residual of that file; the reported line 74 is a source-map remap artifact — the rename ternary at :73 records both arms taken by pullRequestOwnersArms.test.ts.
  • Consumer: grep -n assignees src/plugins → only blunderbuss.ts:165 (excluded set).

Separate reporting: the unit (vite) and e2e (tsc+ncc source-map) coverage maps come from different transforms and are not combined (see vitest.e2e-coverage.config.mjs).

Recommendation

  • add an assignees case to __tests__/bundle/blunderbussSettings.test.ts (pull_request opened with exclude_approvers: true, one reviewer assigned under a mixed-case login → only the other is requested; both assigned → blunderbuss: no reviewer candidates for #1 and no request)

Priority

  • Impact: medium (covered by unit tests but not end-to-end)
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 20d49e7

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
23
Merge medio
1g 18h
PR unite (30g)
191

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.