Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] handlePullReq's jobs-input error arms are never exercised end-to-end through dist/index.js

Aperta
  • Qualcosa non va?
#309 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@hivecommons-hive ci sta già lavorando.

Dal 4/10/2026.

  • #310 di @hivecommons-hive — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
typescript
Ambito
testing

Direzione di ricerca

Start with __tests__/bundle and read src/pullReq/handlePullReq.ts and src/pullReq/onPrLgtm.ts to understand the existing end-to-end test setup and the uncovered branches. Run npm run test:coverage:e2e to establish the baseline. Done when bundle-level tests exercise the listed jobs-input error cases and the coverage increases as described.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

src/pullReq/handlePullReq.ts runs the jobs input after the registered pull-request handlers. Three of its arms are reached by no __tests__/bundle suite, so the shipped bundle's behaviour on them is unmeasured:

  • lines 62-66: the lgtm job's catch (an onPrLgtm failure is returned as a value) and the default arm (could not execute <job>. May not be supported)
  • lines 75-80: the TypeError: error handling pull request: … rethrow and the core.setFailed that ends the run
  • src/pullReq/onPrLgtm.ts line 30: could not get labels from issue when the labels read fails

Evidence

  • Unit: npx vitest run --coverage on main @ 3fc21f2 — handlePullReq.ts 100 / 100 / 100 / 100, onPrLgtm.ts 100 / 100 / 100 / 100 (__tests__/pullReqTest/handlePullReq.test.ts, onPrLgtm.test.ts).
  • End-to-end: npm run test:coverage:e2e on main @ 3fc21f2 (Node v26.10.0, vitest 5.0.3, local run 2026-10-04) — handlePullReq.ts 80.76 % lines, uncovered 46,62-66,75-80; onPrLgtm.ts 83.33 % lines, uncovered 19,30.

Covered by unit tests but not end-to-end → medium.

Line 46 (jobs empty and no registered handlers) and onPrLgtm.ts line 19 (a pull_request payload without pull_request.number) are not reachable from a real pull_request event and are out of scope.

Recommendation

  • __tests__/bundle/pullReqJobsArms.test.ts: a pull_request synchronize run with an unsupported jobs entry fails naming the job after the handlers have run; one whose lgtm job's GET /issues/1 answers 500 fails with could not get labels from issue and deletes nothing; jobs: lgtm <unsupported> removes the label and still fails the run

Measured with that file: handlePullReq.ts 80.76 → 96.15 % e2e lines (only 46 left), onPrLgtm.ts 83.33 → 91.66 % (only 19 left).

Priority

  • Impact: medium
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 709cb6c

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
23
Merge medio
1g 9h
PR unite (30g)
122

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.