Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] the configured blunderbuss section (ignore_authors, exclude_approvers, max_request_count) is never driven through dist/index.js

Aperta
  • Qualcosa non va?
#290 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@hivecommons-hive ci sta già lavorando.

Dal 4/10/2026.

  • #291 di @hivecommons-hive — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, typescript
Ambito
ci-cd, testing

Direzione di ricerca

Start with tests/bundle/blunderbussSettings.test.ts and the existing bundle cases in bundle.test.ts:1010–1086; run the bundle suite against dist/index.js with fakeGithub. Cover ignore_authors, exclude_approvers, and max_request_count through pull_request opened, with the expected reviewer-request behavior and the stated coverage targets serving as done.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t needs-kind quality testing

Finding

docs/configuration.md documents five blunderbuss: options. The bundle suite (__tests__/bundle, the only place the shipped dist/index.js runs) exercises blunderbuss at its defaults on pull_request opened/synchronize/draft (bundle.test.ts:1010–1066) and request_count via /auto-cc (bundle.test.ts:1068–1086). The other three options never reach dist/:

  • ignore_authors — src/plugins/blunderbuss.ts:35 (lowercasing) and 159–161 (the skip)
  • exclude_approvers — the true arm of the candidate set at :171
  • max_request_count — :185–189 (the cap and the "already has N requested reviewers" return)

Each changes the action's API traffic (whether and how many reviewers POST …/pulls/1/requested_reviewers carries), so they are behaviour of the shipped bundle, not lookup-table variations.

Evidence

  • Unit: npx vitest run --coverage on main @ 3fc21f2 (Node v26.10.0, vitest 5.0.3, @vitest/coverage-v8 5.0.3): blunderbuss.ts 100 % lines / 100 % branches (__tests__/plugins/blunderbuss.test.ts).
  • End-to-end: npm run test:coverage:e2e (#274) on the same revision, local run with --coverage.reporter=lcovonly: blunderbuss.ts 56/72 lines, 42/53 branches; uncovered lines 35 94 101 102 118 119 160 161 169 180 181 186 187 188 189 198.
  • The two figures are stated separately: unit and e2e statement maps come from different transforms and do not line-merge (#235).

Recommendation

  • __tests__/bundle/blunderbussSettings.test.ts (new file): drive pull_request opened through dist/index.js against fakeGithub with an org prow.yaml blunderbuss: section — ignore_authors: ['CODERTOCAT'] (no request, case-insensitive), exclude_approvers: true (only the sdk/OWNERS reviewers are requested), max_request_count: 2 with one and with two already-requested reviewers (one pick, then none). Expected after: blunderbuss.ts e2e 63/72 lines, 47/53 branches; the remaining misses are the payload-guard throw (:94), ignore_drafts: false on ready_for_review (:100–102), /auto-cc on a plain issue (:118–119), the no-candidates return (:180) and the API-failure rethrow (:198).

Priority

  • Impact: medium — unit-covered, not end-to-end-covered (priority 2 under the coverage evidence rules)
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
23
Merge medio
1g 2h
PR unite (30g)
98

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.