Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Wrong `ObjectStore` key logged when the backup object store can't be retrieved in the instance sidecar

Aperta Adatta ai principianti
  • Qualcosa non va?
#1,142 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
88/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, postgresql
Ambito
backend, databases

Direzione di ricerca

Esamina internal/cnpgi/instance/backup.go in Backup e internal/cnpgi/instance/metrics.go in Collect. Confronta la chiave passata a GetBarmanObjectKey() con la chiave registrata in ciascun log di errore, quindi verifica che entrambi i percorsi riportino la chiave ObjectStore del backup richiesto quando la ricerca non riesce.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

In the instance sidecar, two code paths fetch the cluster's backup ObjectStore with GetBarmanObjectKey(), but their error log reports GetRecoveryBarmanObjectKey():

internal/cnpgi/instance/backup.go (Backup):

var objectStore barmancloudv1.ObjectStore
if err := b.Client.Get(ctx, configuration.GetBarmanObjectKey(), &objectStore); err != nil {
 contextLogger.Error(err, "while getting object store", "key", configuration.GetRecoveryBarmanObjectKey())
 return nil, err
}

internal/cnpgi/instance/metrics.go (Collect) has the same lines.

So when the lookup fails, the key field names a different object from the one that was requested:

  • on a cluster without a recovery source (the usual case), RecoveryBarmanObjectName is empty, so key has an empty name;
  • on a cluster bootstrapped from an ObjectStore through externalClusters, key names the recovery ObjectStore, which exists, pointing the reader at the wrong object.
Impact

Low, but confusing. The error message itself (for example objectstores.barmancloud.cnpg.io "s3-store" not found, or ... is forbidden) still has the right name, so the information is in the log line. But the structured key field contradicts it, and anything that filters or alerts on key gets the wrong value. Collect runs on every metrics scrape, so a missing or forbidden ObjectStore repeats the misleading line on every scrape.

This is the same kind of problem as #539/#504, which were about the operator pre-hook in reconciler.go. These two lines are on the instance side and weren't covered there.

History

The backup.go line dates from e4735a2 (#83, "separate recovery object store from replica source"). The metrics.go one was added in 33172b6 (#459) with the same lines. Open PR #1076 touches the surrounding code in backup.go but leaves this line as it is.

Proposed fix

Log configuration.GetBarmanObjectKey() in both places, the key that is actually passed to Get. I'm happy to send the PR.

How this was found

While working on #1140 on my fork, I ran an AI code review (Claude Code) over my change. It flagged the mismatched key in backup.go, even though my change didn't touch that line. I then searched the code base for the same pattern, which found the copy in metrics.go, and confirmed both on main by reading the code. I haven't triggered the failing lookup on a live cluster, so the error messages quoted above are examples, not captured output.

I used an AI assistant (Claude) to help find this and draft this issue, as the AI policy asks for disclosure.

Lingua principale
Go
Stelle
196
Fork
76
Merge medio
4g 13h
PR unite (30g)
19

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cloudnative-pg/plugin-barman-cloud

Tutte le issue di cloudnative-pg/plugin-barman-cloud

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.