Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Challenging to diagnose bad expressions when using numerical comparison operators.

Aperta
#123 5 commenti 1 reazione 1 assegnatario Vedi su GitHub

@klarose ci sta già lavorando.

Dal 27/9/2025.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

enhancement

I have an expression where one side of a comparison operator fails (e.g. undeclared reference). The result is a "no matching overload" error, which isn't very helpful. I expect to see the original failure bubble up to the top of the evaluation.

E.g.

python3 -m celpy -n 'bad < 113.0'
ERROR: <input>:1:1 found no matching overload for 'relation_lt' applied to '(<class 'celpy.evaluation.CELEvalError'>, <class 'celpy.celtypes.DoubleType'>)'
    | bad < 113.0
    | ^

While the offending part of the expression is still in the output, it's still fairly misleading, and could cause code trying to customize error handling to do the wrong thing.

I took a quick gander where the failure occurs, and it seems to be that the builtin comparison operators don't have an overload for the CELEvalError class. Many of the others do. I'm not sure if this was a miss or on purpose.

Either way, hacking this in seemed to fix the problem:

diff --git a/src/celpy/evaluation.py b/src/celpy/evaluation.py
index 799b05c..8545a02 100644
--- a/src/celpy/evaluation.py
+++ b/src/celpy/evaluation.py
@@ -228,10 +228,22 @@ class CELEvalError(Exception):
     def __rpow__(self, other: Any) -> "CELEvalError":
         return self
 
+    def __lt__(self, other: Any) -> "CELEvalError":
+        raise self
+
+    def __le__(self, other: Any) -> "CELEvalError":
+        raise self
+
+    def __gt__(self, other: Any) -> "CELEvalError":
+        raise self
+
+    def __ge__(self, other: Any) -> "CELEvalError":
+        raise self
+
     def __eq__(self, other: Any) -> bool:
         if isinstance(other, CELEvalError):
             return self.args == other.args
-        return NotImplemented
+        raise self
 
     def __call__(self, *args: Any) -> "CELEvalError":
         return self

I can submit a PR if there's interest.

Lingua principale
Python
Stelle
174
Fork
40
Nessuna PR unita negli ultimi 30g

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cloud-custodian/cel-python

Tutte le issue di cloud-custodian/cel-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.