`gh pr checks` exits 1 for "no checks reported", the same code as failed checks

Aperta
  • Qualcosa non va?
#14,882 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
50/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, go
Ambito
cli

Direzione di ricerca

Start in pkg/cmd/pr/checks/checks.go, where populateStatusChecks returns a plain error when the rollup has no nodes, then compare with how internal/ghcmd/cmd.go maps cmdutil.NewNoResultsError to exit 0. Choose between the two options in the issue, which needs a maintainer decision, and update the 'Additional exit codes' help text. Done means a PR with no checks exits with a code distinct from failed checks, with the --watch loop still waiting, and a test covering it.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs-triage
Describe the bug

gh pr checks <pr> on a pull request whose head commit has no check runs or statuses prints no checks reported on the '<branch>' branch and exits 1. Failed checks also exit 1, so a script or an AI coding agent that runs gh pr checks just to look at CI state cannot tell "nothing ran" from "something failed" without parsing the message.

This was asked for in #9390, but #9452 closed that issue by documenting only exit code 8 (pending). The "no checks" case still exits 1 in gh 2.102.0, and gh pr checks --help doesn't document it. #9682 covers only the --required variant ("no required checks reported").

Steps to reproduce the behavior

On any pull request without checks, for example a merged PR in a repository whose Actions did not run for it:

$ gh --version
gh version 2.102.0 (2026-09-30)
$ gh pr checks 414 --repo G-Ivan-A/mango_ba_prompts; echo "exit=$?"
no checks reported on the 'issue-413-e424ca2a7c62' branch
exit=1
$ gh pr view 414 --repo G-Ivan-A/mango_ba_prompts --json statusCheckRollup --jq '.statusCheckRollup | length'; echo "exit=$?"
0
exit=0

A PR with a failing check gives the same exit=1.

Expected vs actual behavior
  • Expected: "no checks" can be told apart from "checks failed" by exit code, and the code is documented under "Additional exit codes" in gh pr checks --help.
  • Actual: both exit 1, and only the message text tells them apart.
Impact

In link-assistant/hive-mind#3922, an AI agent ended a successful session with …; gh pr checks 414 --repo … to look at the PR state. Because the shell exited 1, the orchestrator treated the last tool call as a failed verification and marked the whole session as failed. electron/electron#49630 hit the same problem in CI scripts.

Workarounds
  • gh pr view <pr> --json statusCheckRollup --jq '.statusCheckRollup | length' returns 0 with exit 0 when there are no checks.
  • Match the exact text no checks reported on the '<branch>' branch on exit 1. This is what hive-mind now does.
Suggested fix

In pkg/cmd/pr/checks/checks.go, populateStatusChecks returns a plain error:

if len(statusCheckRollup.Nodes) == 0 {
    return nil, checkCounts{}, fmt.Errorf("no checks reported on the '%s' branch", pr.HeadRefName)
}

Either of these would fix it:

  1. Return cmdutil.NewNoResultsError(fmt.Sprintf("no checks reported on the '%s' branch", pr.HeadRefName)). internal/ghcmd/cmd.go already maps NoResultsError to exit 0 and prints the message on a TTY, as gh label list, gh workflow list and others do. The --watch loop would need to keep treating "no checks yet" as "keep waiting" (see #7401).
  2. If changing exit 1 → 0 is too breaking for scripts that rely on it, return a distinct, documented code for "no checks". This mirrors exit 8 for pending, and the same code could serve the --required case in #9682.

In both cases, add the code to the "Additional exit codes" help text.

Lingua principale
Go
Stelle
46.8k
Fork
9.2k
Merge medio
1g 14h
PR unite (30g)
60

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cli/cli

Tutte le issue di cli/cli

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.