SKIPPED rules have no reason in the XLSX or JSON report, though the FAQ says they do

Aperta
  • Qualcosa non va?
#1,897 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@SFJohnson24 ci sta già lavorando.

Dal 9/11/2026.

  • #1901 di @SFJohnson24 — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
65/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
data

Direzione di ricerca

Start with the referenced sdtm_report_data.py lines to understand how skipped results are handled, then trace the Issue Details path for JSON and XLSX output; the issue says that path has not been traced. Compare the normal reports with -rr output and the FAQ statement. Done when skipped reasons appear in JSON and XLSX as documented, or the FAQ is updated to direct readers to -rr.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

reporting
Standard

Custom (TIG v1.0 with the SDTM substandard. TIG is not an option in this template.)

Reference Rule ID(s)

CG0176, TIG0405

Conformance Rule ID(s) (if published in CORE)

CORE-000001

JIRA Ticket

None

CLI Command Used (if applicable)
./core validate -s tig -v 1-0 -ss SDTM -uc INDH -ct sdtmct-2026-09-25 -d <datasets> -r CORE-000001 -of JSON -o out

Run on the v1.0.0 release build, core-ubuntu-22.04.tar.gz.

Rule YAML
Unchanged from the v1.0.0 cache. The behavior is not specific to this rule.
Attach any sample test data file(s)

Any study where the rule does not apply reproduces this. The run used synthetic DM, CM and MH XPT files containing no real patient data, and these can be shared on request.

Attach any output report and/or log file(s)

With -of JSON, the rule is SKIPPED and neither issue section gives a reason:

"Rules_Report": [{"core_id": "CORE-000001", "status": "SKIPPED", ...}],
"Issue_Details": [],
"Issue_Summary": []

With -of XLSX, the Issue Details and Issue Summary tabs contain only their header rows.

With -of JSON -rr, the reason is present in results_data:

{"executionStatus": "skipped", "dataset": "MH",
 "message": "Rule skipped - doesn't apply to domain for rule id=CORE-000001, dataset=MH",
 "errors": [{"dataset": "MH", "error": "Outside scope", ...}]}
Expected output

docs/faq.md says: "Rules with a status of SKIPPED will include a reason in the Issue Details."

Either the XLSX and JSON reports should show the reason, or the FAQ should point to -rr.

Any Additional Information

The issue summary excludes SKIPPED results, for example in sdtm_report_data.py. The path that builds Issue Details was not traced.

This matters because a skip caused by a missing column looks the same as a skip caused by scope, so a reviewer cannot tell from the report which rules were legitimately out of scope.

The SQL engine's Rules_Report already has a skip_reason field, which may be a useful model.

Found and reproduced with Claude Code.

Lingua principale
Python
Stelle
125
Fork
50
Merge medio
7h 40m
PR unite (30g)
14

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cdisc-org/cdisc-rules-engine

Tutte le issue di cdisc-org/cdisc-rules-engine

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.