Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Commit prebuilt Appduct playground apps as end-to-end fixtures

Chiusa
#476 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@V3RON ci sta già lavorando.

Dal 12/10/2026.

  • #493 di @V3RON — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
57/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
android, ios, typescript

Direzione di ricerca

Start with e2e/helpers/cli.test.ts and src/source-hygiene.test.ts to follow the existing test patterns, then build Appduct at the pinned commit and add the apps under e2e/fixtures/appduct/. Add the README with build details and SHA-256 values, and the fast e2e checksum and tracking checks. Done when the listed tests pass and the documented app ids and arm64 architecture match the built fixtures.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

task:ready

Part of #466.

Scope

After this PR the repo holds two ready-made sample apps: an iOS simulator
build and an Android debug build of Appduct's native playground. Both are
built from one pinned Appduct commit. The agent-device slow tests (#477) install
them without building an app or downloading anything.

In short

Today simlock's repo has no app to install, so a test cannot show that an
agent's install of a local app works through simlock. This task adds two
built apps under e2e/fixtures/appduct/, with a README that says where they
came from and how to build them again.

A fixture app here is a built app committed to the repo for tests, for
example e2e/fixtures/appduct/android/AppductPlayground.apk.

flowchart LR
  A[Appduct repo at the pinned commit] --> B[xcodebuild / gradlew]
  B --> C["e2e/fixtures/appduct/ (new)"]
  C --> D[#477 slow tests: agent-device install]

If this goes wrong: no simlock user notices. #477's slow tests fail at
install, or cannot find the screen ids they click.

Technical spec

Modules touched
  • e2e/fixtures/appduct/README.md (new)
  • e2e/fixtures/appduct/ios/AppductPlayground.app/ (new, about 1.6 MB)
  • e2e/fixtures/appduct/android/AppductPlayground.apk (new, about 10 MB)
  • e2e/appduct-fixtures.test.ts (new, fast e2e lane)
  • src/source-hygiene.test.ts (changed: skips files under e2e/fixtures/)
flowchart LR
  T["e2e/appduct-fixtures.test.ts (new)"] --> R["fixtures/appduct/README.md (new)"]
  T --> F["fixtures/appduct/ios, android (new)"]
  H["src/source-hygiene.test.ts (changed)"] -. skips .-> F

The source:

  • Repo: https://github.com/callstackincubator/appduct.
  • Pin: tag v0.15.0, commit 0e68131bdd4b8a789314812caf1995b496c52ae9.
    It is the newest release. It holds the last playground-native change
    (7edfa7d) and the last native SDK change (0963162).
  • The builds in the local ../cordierite checkout are older than the pin.
    Do not copy them; build fresh at the pin.

Build commands (they go in the README word for word):

# iOS, from playground-native/ios at the pin (needs Xcode and xcodegen)
xcodegen generate
xcodebuild build -project AppductPlayground.xcodeproj -scheme AppductPlayground \
  -configuration Debug -sdk iphonesimulator \
  -destination 'generic/platform=iOS Simulator' -derivedDataPath build \
  ARCHS=arm64 CODE_SIGNING_ALLOWED=NO
# -> build/Build/Products/Debug-iphonesimulator/AppductPlayground.app

# Android, from playground-native/android at the pin (needs JDK 17 and ANDROID_HOME)
./gradlew :app:assembleDebug
# -> app/build/outputs/apk/debug/app-debug.apk, committed as AppductPlayground.apk

The README says:

  • the repo, the tag and the full commit;
  • the build commands above, and where each output is copied;
  • the tool versions used for this build (Xcode, xcodegen, JDK, Android SDK
    platform);
  • the app ids: iOS com.callstack.appduct.playgroundnative, Android
    com.callstack.appduct.playground;
  • the screen ids #477 uses, from Appduct's playground contract: tab-tools,
    tab-status, connection-state, call-count;
  • that the iOS build runs on arm64 simulators only (Apple silicon Macs);
  • a table of every fixture file with its SHA-256, in the format below;
  • how to refresh: build at a new pin, replace the files, update the pin and
    the table in the same commit.

The README's fixed lines, which the test parses (everything else is free text):

Repo: https://github.com/callstackincubator/appduct
Commit: `0e68131bdd4b8a789314812caf1995b496c52ae9`

## Files

| File | SHA-256 |
| --- | --- |
| `android/AppductPlayground.apk` | `3f5a…` (64 hex digits) |
| `ios/AppductPlayground.app/AppductPlayground` | `9c1e…` (64 hex digits) |
  • "Names the Appduct repo" means a line Repo: https://github.com/callstackincubator/appduct.
    The commit is the line Commit: followed by 40 lowercase hex digits in backticks.
  • The table is the only table under the ## Files heading. Its first column
    is the path relative to e2e/fixtures/appduct/, in backticks; its second
    is the SHA-256 as 64 lowercase hex digits, in backticks. One row per file;
    the README itself has no row.
  • The test splits each row on | and trims each cell, so the padding oxfmt
    adds when it realigns the table (lefthook format on *.md) changes
    nothing.

Debug builds are used on both platforms, as Appduct's own device suite does.
The iOS build is unsigned; the arm64 linker signs it ad hoc, which the
simulator accepts. The Android build is signed with the builder's debug key.

Contract and event changes

None. Searched: the only file under src/ it changes is the test src/source-hygiene.test.ts; no contract shape, schema or event is touched.

Other code on the same state

Searched for fixtures, .gitattributes, LFS and the globs that reach e2e/:

  • No e2e/fixtures/ directory exists today. No .gitattributes and no git
    LFS in the repo. The files go in as ordinary git blobs. The repo's pack is
    35.7 MiB today; this adds about 11.5 MB, and every refresh adds as much
    again to history.

  • vitest.config.ts e2e project includes e2e/**/*.test.ts. Only the new
    test file matches; the fixture directory holds no test file.

  • lefthook.yml formats staged *.{ts,tsx,js,mjs,json,md,yml,yaml}. It
    formats the README. The built bundle holds only Info.plist, PkgInfo,
    the executable and its debug dylibs, so no fixture file matches.

  • package.json files ships only dist, so the fixtures never reach the
    npm package.

  • e2e/tsconfig.typecheck.json includes **/*.ts; no fixture file is
    TypeScript. Fallow reads only JS and TS sources.

  • src/source-hygiene.test.ts lists every tracked file with git ls-files
    and fails "contain no raw NUL byte" on any file holding a 0x00 byte. The
    APK, the Mach-O executable, its dylibs and the binary Info.plist all hold
    NUL bytes, so as it stands the test would fail on this PR. The fixtures
    win: the test skips paths under e2e/fixtures/ (built binaries, never
    searched as text), and its doc comment and title say so ("tracked files
    outside e2e/fixtures/ contain no raw NUL byte, so grep and ripgrep can
    search them"). It still sees every other tracked file.

Nothing else reads or writes these paths.

Rules in play
  • testing.md: the checksum test must go red when a fixture byte or a
    README hash changes. Rule 4: the hygiene test's narrowed claim must say
    what it skips.
  • safety.md: no implicit downloads. The apps are committed, so no test
    fetches one.
  • documentation.md: the README is a maintainer file under e2e/, not an
    end-user doc.
Tests

Seam: a fast-lane vitest file that lists the fixture files with
git ls-files -s e2e/fixtures/appduct (tracked files only, so a Finder
.DS_Store or a rebuild leftover on disk changes nothing) and reads the
README; it starts no daemon. Model: the describe/it shape of
e2e/helpers/cli.test.ts, and src/source-hygiene.test.ts for the
git ls-files call.

  • every tracked file under e2e/fixtures/appduct/ except the README is
    listed in the README's table, and the SHA-256 of the file on disk (read
    with fs, not the git blob id) matches the one listed
  • the tracked files include ios/AppductPlayground.app/Info.plist,
    ios/AppductPlayground.app/AppductPlayground and
    android/AppductPlayground.apk, under exactly those names
  • the README's table lists no file that git does not track under
    e2e/fixtures/appduct/
  • the iOS executable ios/AppductPlayground.app/AppductPlayground is
    tracked with mode 100755
  • the README has the Repo: line naming
    https://github.com/callstackincubator/appduct and a Commit: line with
    40 lowercase hex digits
  • (src/source-hygiene.test.ts) the hygiene test's file list holds no path
    under e2e/fixtures/ and still holds e2e/appduct-fixtures.test.ts

Done when

  • pnpm test:e2e e2e/appduct-fixtures.test.ts and
    pnpm test:unit src/source-hygiene.test.ts pass with the fixtures committed.
  • Changing one byte of a fixture, or one digit of a README hash, makes the
    checksum test fail; git update-index --chmod=-x on the iOS executable
    makes the mode test fail.
  • On a Mac:
    plutil -extract CFBundleIdentifier raw e2e/fixtures/appduct/ios/AppductPlayground.app/Info.plist
    prints com.callstack.appduct.playgroundnative, and
    lipo -info e2e/fixtures/appduct/ios/AppductPlayground.app/AppductPlayground
    names arm64.
  • With the Android SDK: aapt dump badging e2e/fixtures/appduct/android/AppductPlayground.apk
    (from $ANDROID_HOME/build-tools/<version>/) names package
    com.callstack.appduct.playground.
  • git ls-remote https://github.com/callstackincubator/appduct v0.15.0
    prints the commit the README names.
  • The bundle id, the package name and the arm64 architecture above are
    checked by hand at each refresh; #477's slow tests prove them on every
    run, since they install and launch the apps by those ids.
  • That both apps install and run on real devices is proven by #477's slow
    tests, not here.

Out of scope

  • A script or CI job that rebuilds the apps. The README's commands are the
    record.
  • Release builds, and Appduct's Expo and Flutter playgrounds.
  • git LFS.
  • Any test that installs the apps (#477).

Depends on

Approval

  • Approved for delivery

Written by an agent.

Lingua principale
TypeScript
Stelle
19
Fork
1
Merge medio
7h 49m
PR unite (30g)
228

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di callstackincubator/simlock

Tutte le issue di callstackincubator/simlock

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.