Remove Hermes vendoring once React Native ships a Hermes with Node-API
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Refactoring
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Tranquilla
- Stack tecnologico
- android, cpp, react-native, ruby, typescript
- Ambito
- build-system, mobile, tooling
Direzione di ricerca
Per prima cosa controlla version.properties di React Native e verifica il tag Hermes corrispondente per API/napi/, quindi verifica che gli artefatti Android e Apple distribuiti espongano i simboli e gli header Node-API richiesti. Esamina i file CLI, Gradle, C++, podspec, workflow, app, documentazione e package elencati prima di rimuovere i percorsi di vendoring. Il lavoro è completato quando l’app di test viene compilata e supera i test con React Native standard, senza REACT_NATIVE_OVERRIDE_HERMES_DIR né una configurazione build-from-source.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Tracking the removal of vendor-hermes and everything that hangs off it, gated on React Native shipping a Hermes that carries Node-API.
Why we vendor today
After #372 we no longer patch Hermes — we build it from a pinned commit on the static_h branch, which carries the first-party Node-API implementation under API/napi (target hermesNapi). The pin lives in packages/host/src/node/cli/hermes.ts, and the host calls into it directly (hermes_napi_create_env in packages/host/cpp/CxxNodeApiHostModule.cpp, with the hermes_napi_host struct mirrored in packages/host/cpp/HermesNapiHost.hpp).
React Native's own Hermes doesn't have that code yet, which is the only reason we need REACT_NATIVE_OVERRIDE_HERMES_DIR — and therefore the only reason consumers have to build React Native from source at all.
The gate
React Native doesn't tag every nightly, so read the head of the default branch rather than a release:
packages/react-native/sdks/hermes-engine/version.propertieson the default branch offacebook/react-native→HERMES_VERSION_NAME.- Check whether
facebook/hermesat taghermes-v$HERMES_VERSION_NAMEhas anAPI/napi/directory.
State as of 2026-09-23:
HERMES_VERSION_NAME=260318099.0.2(unchanged since at least 2026-09-14 — nine consecutive checks, 2026-09-14 through 2026-09-23, have all read the same value)API/napi/hermes_napi.h→ still 404 athermes-v260318099.0.2, whileAPI/hermes/hermes.hresolves at the same tag — so the tag is valid and still carries no Node-API. No open PR references this issue. Still nothing to poll for besides re-checking the gate.
That's the cheap signal to poll. Something like:
version=$(curl -fsSL https://raw.githubusercontent.com/facebook/react-native/main/packages/react-native/sdks/hermes-engine/version.properties | sed -n 's/^HERMES_VERSION_NAME=//p')
curl -fsSLo /dev/null "https://raw.githubusercontent.com/facebook/hermes/hermes-v$version/API/napi/hermes_napi.h" && echo "Node-API has landed in RN's Hermes ($version)"
Necessary, but not sufficient
The version check tells us the source has Node-API in it; before dropping anything we still need the shipped artifacts to expose it:
- the
hermes-engineAAR'slibhermesvm.somust exporthermes_napi_create_env(Hermes has to build thehermesNapitarget and keep it visible under its global-fvisibility=hidden, cf. facebook/hermes#2106 — see the pin comment inhermes.ts), - the same for the Hermes framework shipped through the podspec on Apple platforms,
hermes_napi.h(or an equivalent public header) needs to reach us through prefab / the framework headers, soHermesNapiHost.hppcan include it instead of mirroring the struct,IHermes::getVMRuntimeUnsafe()still has to be reachable from the JSI runtime.
The real acceptance test is the test app building and passing against a stock React Native with no REACT_NATIVE_OVERRIDE_HERMES_DIR set and no build-from-source configuration.
What removal touches
packages/host/src/node/cli/hermes.ts— thevendor-hermescommand, plus its registration inpackages/host/src/node/cli/program.ts(a breaking CLI change, so it wants a major changeset)packages/host/android/build.gradle:7-17— theREACT_NATIVE_OVERRIDE_HERMES_DIRguard, andpackages/host/src/node/gradle.test.ts, which asserts that errorpackages/host/scripts/patch-hermes.rband itsrequire_relativein the podspec.github/workflows/check.yml:330-333— the vendoring step in the Android jobapps/test-app/android/gradle.properties—react.buildFromSource=truebecomes unnecessarypackages/host/cpp/HermesNapiHost.hpp— include the realhermes_napi.hinstead of mirroringhermes_napi_host, which also removes the "re-diff on every pin bump" hazarddocs/ANDROID.md— most of it disappears; Android stops needing a source build (see #411 for its current state)README.md(the supported-versions note),packages/host/README.md,AGENTS.md§ Critical Build Dependenciespackages/host/package.json— thereact-nativepeer dependency can widen from a single nightly to a real range
Related
- #177 — prebuilt Node-API Hermes, the interim mitigation if this takes a while
- #392 —
react-native-macosblocked on the same story - #188 — the consumer-side Gradle settings helper, which becomes moot along with the source-build requirement
- Lingua principale
- TypeScript
- Stelle
- 188
- Fork
- 10
- Merge medio
- 2g 17h
- PR unite (30g)
- 3
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di callstackincubator/react-native-node-api
-
Android 🤖
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
-
Sanity check of Hermes source directory via environment variable, when building Android projects ApertaAndroid 🤖 good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
callstackincubator/react-native-node-api#163 · 1 commento ·
-
enhancement good first issue gyp-to-cmake
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
callstackincubator/react-native-node-api#161 · 3 commenti · 1 reazione ·
-
enhancement Host 🏡
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
-
Automatable good first issue
Difficoltà 3/5 1-2 giorni Idoneità per principianti 15/100
callstackincubator/react-native-node-api#424 · 1 commento ·
Tutte le issue di callstackincubator/react-native-node-api
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
bug v2
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
modelcontextprotocol/inspector#2458 · 1 commento ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 75/100
railmapgen/rmp-gallery#4068 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
carbon-design-system/ibm-products#9907 ·