[iOS 15] Header buttons stop responding after pushing and popping a screen over the pager
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 58/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- ios, react-native, swift, typescript
Direzione di ricerca
Start with ios/PagerViewProvider.swift and inspect how setupView() creates the hosting controller; the proposed workaround belongs in a separate PagerViewIOS15NavigationBarCompat.swift file. Reproduce push then pop on an iOS 15 simulator and check whether the navigation bar covers the header buttons. Done means the buttons respond after returning, while iOS 16 and later retain the existing behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Environment
- react-native-pager-view 9.0.4 in the repro app; the relevant code (
PagerViewProvider.setupView()) is unchanged in 9.0.9 - iOS 15.2 simulator (the reporter also reproduced it on a 15.1 device; newer iOS versions are not affected)
- React Native 0.84.1, New Architecture (Fabric)
@react-navigation/{native,stack,bottom-tabs,material-top-tabs}v7,react-native-screens4.27
Description
On iOS 15, after pushing a screen on top of a screen that contains a PagerView and then going back, the React Navigation header buttons (headerLeft / headerRight) stop responding. They never fire again for that screen.
The cause is not React Navigation. On iOS 15 UIHostingController installs SwiftUI's UIKitNavigationBarBridge, which calls -[UINavigationController setNavigationBarHidden:NO] on the enclosing navigation controller whenever the hosting view appears. react-native-screens creates an RNSContainerNavigationController with a hidden bar for the bottom-tab hasTwoStates container; the bridge re-shows an empty UINavigationBar on top of the screen — exactly over the React Navigation header — and that bar swallows every touch there.
Measured with lldb on an iOS 15.2 simulator after push → pop:
UINavigationBar in the window |
what hitTest at the header button returns |
|
|---|---|---|
| before | present at (0 47; 428 44), hidden = NO |
_UINavigationBarContentView (not the button) |
| after the proposed fix | none visible | the React Native button view |
Breakpoint trace of the cause (on -[UINavigationController setNavigationBarHidden:animated:], hidden = NO):
#0 -[UINavigationController setNavigationBarHidden:animated:]
#1 SwiftUI.UIKitNavigationBarBridge.hostingControllerWillAppear(animated:)
#2 SwiftUI._UIHostingView.viewControllerWillAppear(...)
#3 SwiftUI.UIHostingController._viewWillAppear(_:)
...
#16 -[RNSScreenContainerView attachScreen:atIndex:] ← react-native-screens re-attaches the screen on pop
Reproducible Demo
https://github.com/zewillze/react-native-pager-view-ios15-issue
- Run the repro on an iOS 15.x simulator/device.
- Tap a list row (pushes
Detailinside a@react-navigation/stack). - Go back.
- Tap the "Button" or "+" header button — nothing happens.
The screen structure matters: bottom tabs → stack (with a JS header) → material top tabs (the pager). The bottom-tab container provides the hidden UINavigationController, and the pager's UIHostingController is what triggers the bridge when it re-appears.
Optional check without touches, after step 3 — dump the window hierarchy:
po [[[UIApplication sharedApplication] keyWindow] performSelector:@selector(recursiveDescription)]
Before: a UINavigationBar at (0 47; 428 44) with hidden = NO. After the fix: none.
Proposed fix
Wrap the UIHostingController created in ios/PagerViewProvider.swift so it restores the enclosing navigation bar's hidden state around viewWillAppear.
To keep it easy to drop with iOS 15, the workaround lives in its own file (PagerViewIOS15NavigationBarCompat.swift) and every entry point returns early on iOS 16+ via if #available(iOS 16, *). Deleting that file and replacing the single call site with UIHostingController(...) is all that is needed once iOS 15 support is removed — the same isolation pattern used for the iOS 15 scrollEnabled fix (#1148).
The change is 2 files (+68/−1), preserves 9.0.9's ignoreSafeArea: true behaviour, and I have verified it on an iOS 15.2 simulator. I'll open a PR referencing this issue.
- Lingua principale
- TypeScript
- Stelle
- 3.4k
- Fork
- 488
- Merge medio
- 2g 11h
- PR unite (30g)
- 26
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di callstack/react-native-pager-view
-
[iOS] Focused TextInput keeps focus and keyboard after switching pages (v9)Forse già presa @TaduJR l’ha presa 2 giorni fa. Aperta
Difficoltà 4/5 1-2 giorni Idoneità per principianti 69/100
callstack/react-native-pager-view#1192 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 73/100
callstack/react-native-pager-view#1191 ·
I maintainer di solito rispondono entro 1 giorno
-
iOS: PagerScrollDelegate proxies to itself and overflows the stack when the weak originalDelegate diesForse già presa @lvlrSajjad l’ha presa 38 giorni fa. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 25/100
callstack/react-native-pager-view#1146 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
callstack/react-native-pager-view#1144 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
callstack/react-native-pager-view#1141 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di callstack/react-native-pager-view
Issue simili
-
bug P3 UI/UX
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
StellarState/SS-backend#712 ·
I maintainer di solito rispondono entro 1 giorno
-
area: backend bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
snapotter-hq/SnapOtter#3473 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
gitroomhq/postiz-app#2304 ·
I maintainer di solito rispondono entro 1 giorno
-
harlan-agent-ready-to-implement routine:ci-review
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
harlan-zw/unlighthouse#454 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno