feat(web): run concurrent web sessions on one host

Chiusa
  • Qualcosa non va?
#4,190 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #4191 di @kacper-mikolajczak — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
18/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, cli

Direzione di ricerca

Start in packages/contracts/src/device-inventory.ts, where the fixed agent-browser-chrome web device is defined, then follow the three per-device checks in packages/daemon/src/sessions/session-lifecycle/internal/session-open-execution.ts and the device:<id> lock in packages/daemon/src/server/request-binding.ts. Done means two differently named web sessions open and run in parallel, the same name still returns DEVICE_IN_USE, and the router tests the issue lists pass. Pull request #4191 is already open against this issue, so check it before starting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Purpose

Let several agents drive isolated browsers on one host at the same time, the way they already can with one emulator each. Today a host runs only one agent-device web session.

The backend already supports this. agent-browser --session <name> runs isolated browsers in parallel, each with its own browser process, cookies, storage, and history. agent-device already passes the session name through as --session (agent-browser-provider.ts L430). Only agent-device's device model blocks it.

Current behavior (0.21.33)

agent-device open about:blank --platform web --session a
agent-device open https://example.com --platform web --session b
# Error (DEVICE_IN_USE): Device is already in use by session "a".

AGENT_DEVICE_STATE_DIR=$(mktemp -d) agent-device open https://example.com --platform web --session c
# Error (DEVICE_IN_USE): web device agent-browser-chrome is owned by session "a" in workspace "..."

Web inventory returns one fixed device, agent-browser-chrome (device-inventory.ts L53-L60). Three per-device rules then block a second session:

Today's only workaround gives each session its own AGENT_DEVICE_STATE_DIR and AGENT_DEVICE_CLAIMS_DIR. That turns off host-wide device claims for the second daemon and needs a second managed backend install.

Required behavior

  • Each web session holds its own device, agent-browser-chrome:session:<name>. Device selection derives the id before any lock is taken. The conflict check, the claim, and the device:<id> lock then apply unchanged. This mirrors the app devices of ADR 0035 (#3323).
  • Web sessions with different names can open, run commands, batch, and replay in parallel in one daemon.
  • The same name still gets DEVICE_IN_USE, both in one daemon and across daemons that share a claims directory.
  • The device id uses the same normalized session name as the backend's --session. A name the id cannot carry unambiguously is refused with a typed reason.
  • Network dump, audio probe, and recording use only the request's own web provider, never another session's browser or the default one.
  • Closing a web session, or expiring it when idle, closes only that session's browser.

CLI example

agent-device open https://example.com --platform web --session a
agent-device open https://www.iana.org/help/example-domains --platform web --session b
agent-device snapshot --session a   # Page: https://example.com
agent-device snapshot --session b   # Page: https://www.iana.org/help/example-domains

Completion conditions

  • A router test opens two web sessions with different names in parallel. The same name conflicts, including from a second daemon on the same claims directory.
  • A router test runs two fresh web batches and two fresh web replays with different names in parallel.
  • Unit tests cover session-name normalization, teardown closing only its own browser, and network dump and audio probe refusing without a request-scoped provider.
  • The web help topic documents parallel sessions.

Dependencies

None. ADR 0035 and ADR 0029 (policy admission) describe app devices only. If this is accepted, they need an amendment or a new ADR.

Related: #817, #2031, #1868.

Lingua principale
TypeScript
Stelle
5.3k
Fork
377
Merge medio
13h 58m
PR unite (30g)
654

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di callstack/agent-device

Tutte le issue di callstack/agent-device

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.