Plugin request for Buf Schema Registry: protoc-gen-connect-php

Aperta
  • Qualcosa non va?
#2,851 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

  • #2852 di @rastislavnemec — chiusa senza merge

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
docker, go, php
Ambito
api, build-system

Direzione di ricerca

This is a request to register a new remote plugin in the bufbuild/plugins repository, not a code change to the plugin itself. Review the existing plugin directories, such as the connectrpc/go entry, to see the expected layout of a plugin directory, its Dockerfile and plugin.sum. The author has said the files are ready and a PR will follow, so the work is reviewing that PR rather than writing the plugin.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Mandatory

Where is the source code for the plugin?

https://github.com/ftshp/connect-php/tree/main/cmd/protoc-gen-connect-php

The plugin is part of ftshp/connect, an unofficial PHP implementation of the Connect protocol (unary RPCs, PSR-18 client, PSR-15 server). For each service it generates a PHP interface and a client class next to the message classes from protocolbuffers/php. Streaming RPCs are skipped with a warning.

Optional

Does the plugin have a valid semver version?

v0.1.0, from the GitHub release: https://github.com/ftshp/connect-php/releases/tag/v0.1.0. Releases are tagged v* and built with goreleaser. go install github.com/ftshp/connect-php/cmd/[email protected] builds the same binary.

Does the plugin have a dependency on another plugin?

Yes, on protocolbuffers/php (https://github.com/protocolbuffers/protobuf/tree/main/php) for the message classes, like connectrpc/go on protocolbuffers/go. The generated code follows the namespace mapping and reserved-name rules of protoc-gen-php, so both plugins have to run on the same files.

Does the output of this plugin depend on any other external libraries?

Yes, the ftshp/connect Composer package (https://packagist.org/packages/ftshp/connect, Apache-2.0) and google/protobuf.

Proposed name: buf.build/community/ftshp-connect-php. The Dockerfile follows the connectrpc/go one (static Go build of the tagged module, scratch runtime, nobody user). I have the plugin directory and the plugin.sum files ready and will open the PR once this issue is in.

Lingua principale
Dockerfile
Stelle
74
Fork
26
Merge medio
3h 17m
PR unite (30g)
74

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bufbuild/plugins

Tutte le issue di bufbuild/plugins

Issue simili

Altre issue su Backend & API Design

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.