Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Unsigned integer axis maps below-range values to overflow

Aperta Adatta ai principianti
  • Qualcosa non va?
#446 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
76/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
backend

Direzione di ricerca

Leggi include/boost/histogram/axis/integer.hpp intorno alla riga 109 e il contratto degli indici di Axis in doc/concepts/Axis.qbk. Inizia eseguendo repro.cpp con gli header fissati e i comandi di compilazione C++17 forniti; poi esamina la sottrazione senza segno che produce l’indice segnalato. Il lavoro è terminato quando l’input al di sotto dell’intervallo restituisce -1 e incrementa underflow, mentre gli indici elencati all’interno e al di sopra dell’intervallo restano quelli previsti.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

axis::integer<unsigned>(1, 4) maps 0u to overflow. The Axis contract requires underflow for this below-range value.

Reproduced on x86-64 Ubuntu 24.04 with GCC 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1) and Clang 18.1.3 (Ubuntu 1ubuntu1). The examples use C++17 Release builds with -O2, without fast-math. Supplemental verifier controls also used -DNDEBUG.

Tested Boost.Histogram commit: 22740e5082ca99d5717da8d9c31d684be9aaeecf. Dependency headers came from Boost superproject commit afa7af297165ad85978b364eb9df19e098109d9e, whose Histogram gitlink matches that pin.

Master still equals the tested commit as checked on 2026-10-12. Default develop at f9017f94684583eeef80eb230768c932a8a6e76c retains the cited expressions. Develop was read, not tested.

From a fresh directory, prepare the pinned sources:

git clone https://github.com/boostorg/histogram.git histogram
git -C histogram checkout --detach 22740e5082ca99d5717da8d9c31d684be9aaeecf
git clone --no-checkout https://github.com/boostorg/boost.git boost
git -C boost checkout --detach afa7af297165ad85978b364eb9df19e098109d9e
git -C boost submodule update --init --jobs 3 \
  libs/config libs/core libs/mp11 libs/throw_exception libs/variant2 libs/assert

Save this example as repro.cpp:

#include <boost/histogram.hpp>
#include <iostream>

int main() {
  namespace bh = boost::histogram;
  auto h = bh::make_histogram(bh::axis::integer<unsigned>(1, 4));
  h(0u);
  const auto index = h.axis().index(0u);
  std::cout << "index(0)=" << index << " underflow=" << h.at(-1)
            << " overflow=" << h.at(3) << '\n';
  return index == -1 && h.at(-1) == 1 && h.at(3) == 0 ? 0 : 1;
}

Run these commands in Bash with g++ and clang++-18 on PATH:

includes=(-I"$PWD/histogram/include")
for module in config core mp11 throw_exception variant2 assert; do
  includes+=(-I"$PWD/boost/libs/$module/include")
done
for cxx in g++ clang++-18; do
  "$cxx" -std=c++17 -O2 -Wall -Wextra "${includes[@]}" \
    repro.cpp -o "repro-$cxx"
  "./repro-$cxx"
  printf 'exit=%s\n' "$?"
done

Both compiler runs print the observed result below and exit 1 because the expected-value check fails.

The Axis index contract assigns -1 to values below the covered range and size() to values above it. The integer axis interface permits integral value types and defines the interval as [start, stop).

Expected for the single fill: index(0u) == -1, underflow 1, overflow 0, and all three ordinary bins 0. Observed:

index(0)=3 underflow=0 overflow=1

For inputs 0u, 1u, 2u, 3u, 4u, 5u, expected indices are -1,0,1,2,3,3. Observed indices are 3,0,1,2,3,3. The independent Python integer oracle also gives flow-inclusive counts 1,1,1,1,2, compared with observed 0,1,1,1,3.

At integer.hpp:109, x - min_ is evaluated in the unsigned value type before conversion to double. For 0u - 1u, the defined unsigned wrap produces a large positive value that selects overflow.

Issue 437, item 7, discusses extreme signed arithmetic at this same source line. The example here uses small unsigned values.

The verifier checked all values from 0 through 5 on the shifted unsigned axis. A signed axis on [1,4) and an unsigned axis on [0,4) give the required indices and counts. These checks cover the small programs and listed controls. The full library test suite, other compilers, other platforms, and C++14/C++20 builds were not run.

The reproduction example is provided under CC0.

Found by ChipLab's AI verification agents and independently reproduced.

ChipLab ref: CLAB-2026-929

Lingua principale
C++
Stelle
334
Fork
76
Merge medio
18h 2m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di boostorg/histogram

Tutte le issue di boostorg/histogram

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.