Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Bug in biconnected_components when handling multiple (parallel) edges between the same pair of vertices

Aperta
  • Qualcosa non va?
#434 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@jeremy-murphy ci sta già lavorando.

Dal 7/10/2025.

  • #435 di @GlebGrishuhin — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

algorithm priority: high
Version of Boost

1.88.0

Problem description

In a block of parallel edges (e.g., three edges between A and B), only one edge receives the correct biconnected component label.
The rest are incorrectly assigned component ID 0 — even though they belong to the same biconnected component.

Expected behavior

All edges in a block of parallel edges should have the same non-zero component ID

Actual behavior

Only one edge gets the correct component ID; others are assigned 0 — which is wrong

Reproducible example

Problem can be reproduced with such program.

#include <boost/config.hpp>
#include <vector>
#include <list>
#include <boost/graph/biconnected_components.hpp>
#include <boost/graph/adjacency_list.hpp>
#include <boost/graph/properties.hpp>
#include <boost/property_map/property_map.hpp>
#include <iterator>
#include <iostream>

namespace boost
{
    struct edge_component_t
    {
        typedef edge_property_tag kind;
    } edge_component;
}

int main()
{
    using namespace boost;
    typedef adjacency_list<vecS, vecS, undirectedS,
        property<boost::vertex_index_t, std::size_t>,
        property<edge_component_t, std::size_t>  
    > graph_t;

    typedef graph_traits<graph_t>::vertex_descriptor vertex_t;
    typedef graph_traits<graph_t>::vertices_size_type size_type;

    std::vector<std::pair<size_t, size_t>> graph_edges = {
        {0, 1}, {0, 1}, {0, 1}, // block of parallel edges
        {1, 2}, // bridge
        {2, 3}, {2, 3}, {2, 3}, // block of parallel edges
        {3, 4}, // bridge
        {4, 5} // bridge
    };

    graph_t g(graph_edges.size());

    for (const auto& pair : graph_edges)
        add_edge(pair.first, pair.second, g);

    property_map<graph_t, edge_component_t>::type comp_map = get(edge_component, g);

    std::vector<vertex_t> art_points; 

    auto num_comps = biconnected_components(g, comp_map, std::back_inserter(art_points));

    std::cerr << "Found " << num_comps.first << " biconnected components.\n";
    std::cerr << "Found " << art_points.size() << " articulation points.\n";

    graph_traits<graph_t>::edge_iterator ei, ei_end;
    for (boost::tie(ei, ei_end) = edges(g); ei != ei_end; ++ei)
        std::cout << (char)(source(*ei, g) + 'A') << " -- "
        << (char)(target(*ei, g) + 'A')
        << " " << comp_map[*ei] << "\n";

    return 0;
}
Actual output

The proram output contains block index for each edge of graph:

Found 5 biconnected components.
Found 4 articulation points.
A -- B 4
A -- B 0
A -- B 0
B -- C 3
C -- D 2
C -- D 0
C -- D 0
D -- E 1
E -- F 0

Only one of parallel edges A-B has non-zero block index. Same stands for edges C-D.

Picture shows the graph from example. Red vertices indicate articulation points. Each edge is labeled with index of biconnected component (block) to which it belongs Picture makes clear that output of example is incorrect - each group of parallel edges should form a distinct block.

Image
Expected output
Found 5 biconnected components.
Found 4 articulation points.
A -- B 4
A -- B 4
A -- B 4
B -- C 3
C -- D 2
C -- D 2
C -- D 2
D -- E 1
E -- F 0
Lingua principale
C++
Stelle
397
Fork
246
Merge medio
1g 15h
PR unite (30g)
31

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di boostorg/graph

Tutte le issue di boostorg/graph

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.