Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Skip the second `[verify]` pass when the review is skipped and the tree is unchanged

Aperta
  • Qualcosa non va?
#1,002 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
49/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
git, python
Ambito
devtools

Direzione di ricerca

Start by tracing _skip_review_and_commit through _review_verify_gate, _verify_review, verify_review_stories, and _verify_review_commands, then locate the post-dev verify-command-result journal record. Check how verification settings and Git tree state are represented. Done means unchanged trees can reuse a prior result only when enabled, while changes still run verification and the reuse is recorded in the journal.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe your idea

When the review session is skipped (review-not-recommended → review-skipped), _skip_review_and_commit runs the review verify gate, which executes [verify] commands again on a working tree that has not changed since the post-dev verify that just passed. Allow that second pass to reuse the first result when nothing changed.

Why is this needed?

The two passes exist for a good reason: on the review path, a review session can change code between them, and the gate proves what goes into the commit. On the skip-review path no session runs in between, so the second pass re-proves the same tree with the same commands.

With a slow suite this is the dominant cost of a story. In our project [verify] commands = ["npm test"] takes 11–14 minutes on Windows, so every story whose review is skipped spends that time twice. In one run (0.12.0), the post-dev verify-command-result passed at 15:15:32 and the review gate's npm test started in the same second on the identical tree. Checked against main (v0.13.2): _skip_review_and_commit → _review_verify_gate → _verify_review → verify_review_stories → _verify_review_commands still runs the commands unconditionally.

How should it work?

A deterministic check, no LLM involved:

  1. After the post-dev verify passes, record a fingerprint of what it verified: HEAD plus a hash of the working tree, tracked and untracked but not ignored (for example git add -A into a temporary index, GIT_INDEX_FILE, followed by git write-tree), together with the resolved [verify] commands.
  2. At the review gate on the skip-review path, compute the same fingerprint. If it matches, journal a verify-command-result that points to the earlier pass (for example reused_from_sequence: N) instead of running the commands again. The spec-done gates still run as today.
  3. Any difference (a fix session, a review session, an operator edit, a policy change) runs the commands as now.

Because suites can depend on state outside git (services, clocks, caches), it could be opt-in, for example [verify] reuse_unchanged = true, defaulting to today's behaviour.

PR

Not working on it. Happy to test a build on Windows.

Additional context

  • Platform: Windows 11, psmux 3.3.8, Claude Code adapter, stories mode (bmad-loop run --spec), [gates] mode = "none".
  • The journal already has what step 2 needs (verify-command-result with verification_stage and verification_sequence), so reuse stays auditable.
Lingua principale
Python
Stelle
165
Fork
69
Merge medio
1g 1h
PR unite (30g)
79

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bmad-code-org/bmad-loop

Tutte le issue di bmad-code-org/bmad-loop

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.