Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

WebSocket API: signature user data subscription is lost after reconnect

Aperta
  • Qualcosa non va?
#578 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend, networking

Direzione di ricerca

Start with common/src/binance_common/websocket.py and reconnect() around line 916, then follow how userDataStream.subscribe.signature stores subscription state and how callbacks are keyed by subscriptionId. Reproduce with the described local aiohttp WebSocket server and the failing pytest mentioned in the issue. Done means signature subscriptions are restored after reconnect, callbacks use the new subscription ID, and resubscribe failures emit an error.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

A user data subscription made with userDataStream.subscribe.signature (no session.logon) is not restored when the WebSocket API connection reconnects, including the planned reconnect before the 24h limit and after serverShutdown. The bot stops receiving execution reports and balance updates, and no event or error is raised.

Where

common/src/binance_common/websocket.py, reconnect() (line 916 at a54ec0b): user streams are only resubscribed inside if connection.session_logon_request and self.configuration.session_re_logon. A signature subscription stores no logon request, so nothing is sent on the new connection, and user_stream_connections still points to the closed one.

Reproduction

Local aiohttp WebSocket server, no Binance network:

  1. userDataStream.subscribe.signature on a WS API client in single mode; the server replies with subscriptionId: 0.
  2. The server sends serverShutdown (or the reconnect timer fires).
  3. The client opens connection 2, but the server receives no subscribe request on it, and events pushed there never reach the callback.

I have this as a failing pytest and can share it.

Suggested fix

  • Store the subscribe request per subscription, as session_logon_request is stored, and replay it, re-signed with a fresh timestamp, after reconnect.
  • Remap the callbacks to the subscriptionId returned on the new connection instead of assuming it is unchanged. _resubscribe_user_streams on the logon path assumes the same id and does not await the reply.
  • If the resubscribe fails, emit an error event so the application can react.

I'm happy to open a PR along these lines if this approach works for you.

Related, found while testing (each has a failing test, I can open separate issues or PRs)

  • A reply that arrives after asyncio.wait_for(future, 20) timed out raises InvalidStateError in receive_loop (future.set_result on a cancelled future), which ends the loop: the connection stays open but nothing else is received. Fix: skip futures that are done() and pop the id on timeout.
  • In pool mode, subscribe_user_data registers the callback on the next connection in the round robin, not the one that sent the subscribe, so events are dropped.
  • send_request retries signed DELETE (order cancel) after a ReadTimeout; the first request was already delivered, so the retry returns -2011 Unknown order sent. for an order that was cancelled. Retrying only on connect errors and 5xx would avoid it.
Lingua principale
Python
Stelle
3k
Fork
712
Merge medio
1g 5h
PR unite (30g)
4

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di binance/binance-connector-python

Tutte le issue di binance/binance-connector-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.